Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**Sample** facet shows HTML as text #1416

Closed
shotaK opened this issue Jan 9, 2019 · 3 comments
Closed

**Sample** facet shows HTML as text #1416

shotaK opened this issue Jan 9, 2019 · 3 comments

Comments

@shotaK
Copy link
Contributor

shotaK commented Jan 9, 2019

Expected behavior

Sample facet filter should not show HTML as text

Actual behavior

Sample facet filter should shows HTML as text
screen shot 2019-01-09 at 12 58 59 pm

Steps to reproduce behavior

In BigCommerce store admin go to Products -> Product Filtering and activate Sample filter.
Check any category page Sample facet filter.

@Ubersmake
Copy link
Contributor

We've created an internal engineering ticket for this. While #1426 does fix the immediate display issue in the facet filters, there are also issues surrounding the "Refine By" text as well as the parameters that appear in the URL.

@Ubersmake
Copy link
Contributor

There were two PRs that accomplished similar ends, #1426 and #1455 . We ultimately ended up merging #1426 because it better deals with preventing HTML from appearing in product filtering options.

The differences between the two approaches can be read through here:

1426:
1426

1455:
1455

@Ubersmake
Copy link
Contributor

This has been fixed in 3.4.1 as a part of #1426. This should be published to all stores within the next two weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants