Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extremely high number of vulnerabilities found (mostly low) #1741

Closed
jujoco opened this issue Jul 27, 2020 · 3 comments
Closed

extremely high number of vulnerabilities found (mostly low) #1741

jujoco opened this issue Jul 27, 2020 · 3 comments

Comments

@jujoco
Copy link

jujoco commented Jul 27, 2020

My company is using a 4yr old version of cornerstone. I've been tasked with updating our repo so we could be able to create a new custom react checkout page.
Anyway, should I be concerned with the amount of vulnerabilities npm detects?
node v10.16.3
npm v6.9.0

Expected behavior

found 0 vulnerabilities. you're good to go 👍

Actual behavior

found 59799 vulnerabilities (59353 low, 291 moderate, 150 high, 5 critical)

Steps to reproduce behavior

  1. fork repo
  2. cd into project
  3. npm install.
@wwwdepot
Copy link

Mostly are related to the stencil-cli package, I think you should open an issue over there https://github.com/bigcommerce/stencil-cli

@junedkazi
Copy link
Contributor

@jujoco as @wwwdepot pointed out most of it is due to stencil cli which we pull in as dev dependency to test if the bundle generation is successful as part of the travis check. We are woking on addressing these old dependencies.

@bookernath
Copy link
Contributor

This should now be resolved for the most part, closing.

We will separately pursue improvements to CLI, but this should be fixed for Cornerstone by removing the dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants