Modal dialog after add to cart on PDP cannot be closed with "X" or "Continue Shopping" if Product Reviews are disabled

[joeldentici]

Expected behavior

If you disable product reviews on a site, you should be able to get past the modal dialog after adding to cart by continuing shopping (not just proceeding to checkout).

Actual behavior

Due to a JS error in an event fired when the dialog opens, it seems that not all event listeners for closing the dialog get subscribed and therefore the dialog will not close.

Steps to reproduce behavior

1. From BC control panel, go to "Advanced Settings" / "Comments" / "Built-in"
2. Under "Enable for", uncheck "Product Reviews"
3. Save
4. Go to any PDP
5. Configure product and add to cart

From here you will see the described behavior. Re-enabling product reviews makes this go away.

Note, the error that causes this issue is thrown on this line:

cornerstone/assets/js/theme/product.js

Line 31 in b0a1335

$(document).on('opened.fndtn.reveal', () => this.reviewModal.setupFocusableElements(WRITE_REVIEW));

Suggested Fix (confirmed this fixes the issue):

        $(document).on('opened.fndtn.reveal', () => {
            try {
                this.reviewModal.setupFocusableElements(WRITE_REVIEW);
            } catch (e) { /* ignore error that occurs when product reviews are disabled. */ }
        });

[yurytut1993]

Hi @joeldentici!
Thanks for detailed steps to reproduce. This issue should be fixed in release 4.12.1. Try to update and check