You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you disable product reviews on a site, you should be able to get past the modal dialog after adding to cart by continuing shopping (not just proceeding to checkout).
Actual behavior
Due to a JS error in an event fired when the dialog opens, it seems that not all event listeners for closing the dialog get subscribed and therefore the dialog will not close.
Steps to reproduce behavior
From BC control panel, go to "Advanced Settings" / "Comments" / "Built-in"
Under "Enable for", uncheck "Product Reviews"
Save
Go to any PDP
Configure product and add to cart
From here you will see the described behavior. Re-enabling product reviews makes this go away.
Note, the error that causes this issue is thrown on this line:
$(document).on('opened.fndtn.reveal',()=>{try{this.reviewModal.setupFocusableElements(WRITE_REVIEW);}catch(e){/* ignore error that occurs when product reviews are disabled. */}});
The text was updated successfully, but these errors were encountered:
Expected behavior
If you disable product reviews on a site, you should be able to get past the modal dialog after adding to cart by continuing shopping (not just proceeding to checkout).
Actual behavior
Due to a JS error in an event fired when the dialog opens, it seems that not all event listeners for closing the dialog get subscribed and therefore the dialog will not close.
Steps to reproduce behavior
From here you will see the described behavior. Re-enabling product reviews makes this go away.
Note, the error that causes this issue is thrown on this line:
cornerstone/assets/js/theme/product.js
Line 31 in b0a1335
Suggested Fix (confirmed this fixes the issue):
The text was updated successfully, but these errors were encountered: