diff --git a/CHANGELOG.md b/CHANGELOG.md index ca367bbb75..cc8b9822ec 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## Draft +- Remove nanobar (loading progress bar). [#2192](https://github.com/bigcommerce/cornerstone/issues/2192) - Fix Workflow examples missing api host. [#2161](https://github.com/bigcommerce/cornerstone/pull/2161) - Remove sweetAlert. [#2189](https://github.com/bigcommerce/cornerstone/issues/2189) - Apply security updates (April 2022) [#2200](https://github.com/bigcommerce/cornerstone/issues/2200) diff --git a/assets/js/theme/global.js b/assets/js/theme/global.js index 6d2eb56437..2319410bfe 100644 --- a/assets/js/theme/global.js +++ b/assets/js/theme/global.js @@ -12,7 +12,6 @@ import quickView from './global/quick-view'; import cartPreview from './global/cart-preview'; import privacyCookieNotification from './global/cookieNotification'; import carousel from './common/carousel'; -import loadingProgressBar from './global/loading-progress-bar'; import svgInjector from './global/svg-injector'; export default class Global extends PageManager { @@ -27,7 +26,6 @@ export default class Global extends PageManager { menu(); mobileMenuToggle(); privacyCookieNotification(); - loadingProgressBar(); svgInjector(); } } diff --git a/assets/js/theme/global/loading-progress-bar.js b/assets/js/theme/global/loading-progress-bar.js deleted file mode 100644 index f357438bb7..0000000000 --- a/assets/js/theme/global/loading-progress-bar.js +++ /dev/null @@ -1,41 +0,0 @@ -import Nanobar from 'nanobar'; - -export default function () { - // Create the nanobar instance - const nanobar = new Nanobar(); - - // Timer for moving progress bar during ajax calls - let timer = null; - let current = 0; - - function clearTimer() { - if (timer) { - clearInterval(timer); - timer = null; - } - } - - function setTimer() { - clearTimer(); - - current = 0; - timer = setInterval(() => { - current += 3; - if (current <= 100) { - nanobar.go(current); - } else { - clearTimer(); - } - }, 50); - } - - // Attach global jquery handlers to listen for ajax start - $(document).ajaxSend(() => { - setTimer(); - }); - - $(document).ajaxComplete(() => { - nanobar.go(100); - clearTimer(); - }); -} diff --git a/assets/scss/components/_components.scss b/assets/scss/components/_components.scss index 70cef22921..68cbad1353 100644 --- a/assets/scss/components/_components.scss +++ b/assets/scss/components/_components.scss @@ -9,9 +9,6 @@ // Slick carousel @import "vendor/slick/component"; -// Nanobar Ajax loading progress bar -@import "vendor/nanobar/component"; - // Foundation components // ----------------------------------------------------------------------------- diff --git a/assets/scss/components/vendor/nanobar/_component.scss b/assets/scss/components/vendor/nanobar/_component.scss deleted file mode 100644 index 4d8d04f4b5..0000000000 --- a/assets/scss/components/vendor/nanobar/_component.scss +++ /dev/null @@ -1,5 +0,0 @@ -// ============================================================================= -// NANOBAR - AJAX LOADING PROGRESS -// ============================================================================= - -@import "nanobar"; diff --git a/assets/scss/components/vendor/nanobar/_nanobar.scss b/assets/scss/components/vendor/nanobar/_nanobar.scss deleted file mode 100644 index fd83432a65..0000000000 --- a/assets/scss/components/vendor/nanobar/_nanobar.scss +++ /dev/null @@ -1,20 +0,0 @@ -// ============================================================================= -// NANOBAR - AJAX LOADING PROGRESS -// ============================================================================= - -.nanobar { - display: none; - height: remCalc(5px); - pointer-events: none; - top: 0; - user-select: none; - width: 100%; - z-index: 9999; - - .bar { - background-color: stencilColor("pace-progress-backgroundColor"); - height: 100%; - transition: height 0.1s; - width: 0; - } -} diff --git a/package-lock.json b/package-lock.json index be2a1473f3..58fdf4f87b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -13068,11 +13068,6 @@ "dev": true, "optional": true }, - "nanobar": { - "version": "0.4.2", - "resolved": "https://registry.npmjs.org/nanobar/-/nanobar-0.4.2.tgz", - "integrity": "sha1-AcUS5sZi44ViaU9k5KiKJTcy9I8=" - }, "nanomatch": { "version": "1.2.13", "resolved": "https://registry.npmjs.org/nanomatch/-/nanomatch-1.2.13.tgz", diff --git a/package.json b/package.json index 10fe127a6f..2523b90fee 100644 --- a/package.json +++ b/package.json @@ -18,7 +18,6 @@ "jstree": "^3.3.12", "lazysizes": "5.2.2", "lodash": "^4.17.21", - "nanobar": "^0.4.2", "nod-validate": "^2.0.12", "object-fit-images": "^3.2.4", "regenerator-runtime": "^0.13.7", diff --git a/webpack.common.js b/webpack.common.js index 991cb4c84d..c920d79842 100644 --- a/webpack.common.js +++ b/webpack.common.js @@ -77,7 +77,6 @@ module.exports = { jquery: path.resolve(__dirname, 'node_modules/jquery/dist/jquery.min.js'), jstree: path.resolve(__dirname, 'node_modules/jstree/dist/jstree.min.js'), lazysizes: path.resolve(__dirname, 'node_modules/lazysizes/lazysizes.min.js'), - nanobar: path.resolve(__dirname, 'node_modules/nanobar/nanobar.min.js'), 'slick-carousel': path.resolve(__dirname, 'node_modules/slick-carousel/slick/slick.min.js'), 'svg-injector': path.resolve(__dirname, 'node_modules/svg-injector/dist/svg-injector.min.js'), },