fix: STRF-10493 Address markdown helper messy logs #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanarldt
reviewed
Apr 6, 2023
jordanarldt
reviewed
Apr 6, 2023
jordanarldt
approved these changes
Apr 6, 2023
jmwiese
approved these changes
Apr 6, 2023
jairo-bc
approved these changes
Apr 7, 2023
|
🎉 This PR is included in version 5.7.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
JIRA: STRF-10493
markdownhelper produces multi-line logs that are not even needed in debug mode so we remove those logs and enable theRemarkablelib configuration.How was it tested?
Unit tests for
Remarkableconfiguration were enabled.All unit tests are green.
cc @bigcommerce/storefront-team