fix(storefront): STRF-11941 Remove quotes from nonce #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huntario In your screenshot it shows that it has |
|
Talked in Slack about this and the base64 aspect will need to be handled in Storefront - https://github.com/bigcommerce/storefront/blob/e9714a4ba6c2b0e6e377dce47b959d7c15dded9e/src/main/scala/com/bigcommerce/storefront/routers/StorefrontTemplateRouter.scala#L161 - in a separate PR. |
jkanive
approved these changes
Jun 10, 2024
|
🎉 This PR is included in version 5.10.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Remove the quotes from nonce helper.
Collaboration with Merchandising on nonce.
How was it tested?
Run storefront-renderer-2 locally with local paper and paper handlebars via npm link
npm linknpm link @bigcommerce/stencil-papernpm link @bigcommerce/stencil-paper-handlebarscc @bigcommerce/storefront-team cc @jkanive @bc-erich