fix(storefront): STRF-12281 Prevent block and partial helpers from being named prototype methods #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing named prototype methods
huntario
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
💚
To test this out I used npm link to install this PR as a dependency of storefront-renderer-2 and then ran it locally.
I added this to my home.html template file
<div class="container">
{{#block "__proto__"}}STRF-12281 {{/block}}
</div>
This causes the store to throw an error
However, when I run STRF2 with this update, the server error no longer occurs and the error is handled
|
🎉 This PR is included in version 5.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: STRF-12281
What/Why?
Prevent
partialandblockhelpers from allowing names that are the same as native javascript object prototype methods.Rollout/Rollback
Roll back this PR
Testing
Unit tests, ensured that error is not thrown and object prototype is not accessed.
cc @bigcommerce/team-storefront