From 933bae9ca4b09071a364e013e620a4bd49b498a4 Mon Sep 17 00:00:00 2001
From: Jairo Panduro <jairo.panduro@bigcommerce.com>
Date: Fri, 17 Mar 2023 19:35:34 +0100
Subject: [PATCH] fix: Improve strReplace to remove characters

Co-authored-by: Rafa Avila <107151606+rafa-avila-bc@users.noreply.github.com>
---
 .eslintrc                  | 1 +
 helpers/strReplace.js      | 9 ++++-----
 spec/helpers/strReplace.js | 9 +++++++++
 3 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/.eslintrc b/.eslintrc
index a71dddb..c13200c 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -10,6 +10,7 @@
     "node": true,
     "es2017": true // suppport globals (like Promise) up to es2017 (es2018 doesn't have new globals)
   },
+  "ignorePatterns": ["dist/**/*"],
   "rules": {
     "curly": 2,
     "no-eq-null": 2,
diff --git a/helpers/strReplace.js b/helpers/strReplace.js
index e918422..675191b 100644
--- a/helpers/strReplace.js
+++ b/helpers/strReplace.js
@@ -1,6 +1,5 @@
 'use strict';
 const common = require('./lib/common.js');
-const utils = require('./3p/utils');
 const { ValidationError } = require('../lib/errors');
 
 const factory = globals => {
@@ -10,11 +9,11 @@ const factory = globals => {
         newSubstr = common.unwrapIfSafeString(globals.handlebars, newSubstr);
         iteration = common.unwrapIfSafeString(globals.handlebars, iteration);
 
-        if (!utils.isString(str)) {
+        if (typeof str !== 'string') {
             throw new ValidationError("Invalid query parameter string passed to strReplace");
-        } else if (!utils.isString(substr)) {
-            throw new ValidationError("Invalid query paramter substring passed to strReplace");
-        } else if (!utils.isString(newSubstr)) {
+        } else if (typeof substr !== 'string') {
+            throw new ValidationError("Invalid query parameter substring passed to strReplace");
+        } else if (typeof newSubstr !== 'string') {
             throw new ValidationError("Invalid query parameter new substring passed to strReplace");
         }
 
diff --git a/spec/helpers/strReplace.js b/spec/helpers/strReplace.js
index 142190d..00ce0d4 100644
--- a/spec/helpers/strReplace.js
+++ b/spec/helpers/strReplace.js
@@ -29,6 +29,15 @@ describe('strReplace helper', function() {
         ], done);
     });
 
+    it('should remove characters from string', function(done) {
+        runTestCases([
+            {
+                input: '{{strReplace "123-45-6789" "-" ""}}',
+                output: '123456789',
+            },
+        ], done);
+    });
+
     it('should replace multiple if given quantity', function(done) {
         runTestCases([
             {