STRF-9658 logger accepts strings instead of objects

bigcommerce · Mar 2, 2022 · 40c1508 · 40c1508
1 parent 48ff533
commit 40c1508
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/translator/index.js b/lib/translator/index.js
@@ -105,7 +105,7 @@ Translator.prototype.translate = function (key, parameters) {
     try {
         return this._formatFunctions[key](parameters);
     } catch (err) {
-        this._logger.error(err);
+        this._logger.error(err.message);
         return '';
     }
 };

diff --git a/spec/lib/translator.js b/spec/lib/translator.js
@@ -131,6 +131,7 @@ describe('Translator', () => {
 
         expect(translator.translate('hello')).to.equal('');
         expect(loggerStub.error.called).to.equal(true);
+        expect(loggerStub.error.getCall(0).args[0]).to.equal("MessageFormat: Data required for 'name'.")
 
         done();
     });
@@ -143,8 +144,10 @@ describe('Translator', () => {
         }, loggerStub);
 
         const result = translator.translate('items_with_syntax_error', { count: 1 });
+        const errMessage = 'Language File Syntax Error: Expected "plural" or "select" but "p" found. for key "items_with_syntax_error"';
         expect(result).to.equal("");
         expect(loggerStub.error.called).to.equal(true);
+        expect(loggerStub.error.getCall(0).args[0]).to.equal(errMessage);
 
         done();
     });