Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump paper handlebars to 5.10.4 #366

Merged
merged 1 commit into from
Jun 13, 2024
Merged

fix: bump paper handlebars to 5.10.4 #366

merged 1 commit into from
Jun 13, 2024

Conversation

huntario
Copy link
Contributor

@huntario huntario commented Jun 11, 2024

What? Why?

Bump paper handlebars to remove quotes from nonce handlebars helper - bigcommerce/paper-handlebars#309

How was it tested?

  1. Pull PR locally
  2. Within directory use npm link
  3. Inside storefront-renderer-2 run npm link @bigcommerce/stencil-paper
  4. Run storefront-renderer-2 locally and turn on STRF-11672.Enable_nonce_csp_header
  5. Add to script manager
<script>
    {{nonce}}
</script>
  1. See that nonce is shown without outer quotes, and is also displayed in attributes section of the script tag

STRF-11672.Enable_nonce_csp_header on

Screenshot 2024-06-11 at 11 55 44 AM

STRF-11672.Enable_nonce_csp_header off

Screenshot 2024-06-11 at 11 56 19 AM

  1. Ongoing work with Merc, some errors will be expected with STRF-11672.Enable_nonce_csp_header on

cc @bigcommerce/storefront-team

@huntario huntario self-assigned this Jun 11, 2024
@huntario huntario marked this pull request as ready for review June 11, 2024 17:07
@huntario huntario removed their assignment Jun 11, 2024
@huntario huntario requested a review from a team June 11, 2024 17:07
Copy link
Contributor

@jmwiese jmwiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jairo-bc
Copy link
Contributor

@huntario don't forget to merge changelog PR created after merge and release (bigcommerce/paper-handlebars#310), it also will be created in this repo

Copy link
Contributor

@bc-jz bc-jz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given all of @huntario's testing plus me checking this version bump out locally with stencil-cli. I think this PR looks good from a QA perspective.

💚

@huntario huntario merged commit ed47fa8 into master Jun 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants