From 3013fb4ea71e1140aea7e2fefddeb5eb6011560e Mon Sep 17 00:00:00 2001 From: Nabil Cheikh Date: Mon, 14 Oct 2019 13:21:50 -0500 Subject: [PATCH] Adding Support for Node 10 (#525) * chore: updating stencil-styles version and engines for node 10-12 * chore: reduced to node 11 in node engines * chore: updating travis to run all supported node versions to ensure no regressions * chore: removing support for node 11 as it doesn't pass tests * chore: removing non-major node versions from appveyor * chore: merged upstream master * chore: packages updated for node 12 * chore: updated cicd to run node 11 and 12 * chore: updated cicd/travis for node 11 and 12 * Revert "chore: updated cicd to run node 11 and 12" This reverts commit 210b05f29207aa6a72fe96f7cd5f38584a32a9a6. * Revert "chore: packages updated for node 12" This reverts commit 5c6d11c8098e24fd9f1d9333174a718eb72b92f8. * chore: reverting cicd from node 12 changes * chore: updated readme --- .travis.yml | 2 + README.md | 2 +- appveyor.yml | 2 + package-lock.json | 102 +++++++++++++++++++++++++++------------------- package.json | 6 +-- 5 files changed, 67 insertions(+), 47 deletions(-) diff --git a/.travis.yml b/.travis.yml index 212ce101..0c296983 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,6 +7,8 @@ addons: - github.com node_js: - 8 + - 10 + cache: directories: - node_modules diff --git a/README.md b/README.md index 7193761f..58d5ffd7 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ The BigCommerce server emulator for local theme development. ## Install -_Note: Stencil requires the Node.js runtime environment, version 8.x. We do not yet have support for Node 10 or greater._ +_Note: Stencil requires the Node.js runtime environment, version 8.x or 10.x We do not yet have support for Node 12 or greater._ Run `npm install -g @bigcommerce/stencil-cli`. diff --git a/appveyor.yml b/appveyor.yml index a5df4df1..4abfa331 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -1,6 +1,8 @@ environment: matrix: - nodejs_version: "8" + - nodejs_version: "10" + platform: - x86 - x64 diff --git a/package-lock.json b/package-lock.json index 6f15f502..ae9a156e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -46,8 +46,8 @@ } }, "@bigcommerce/node-sass": { - "version": "git://github.com/bigcommerce-labs/node-sass.git#4ea0b8d5f7c418d5bf20b07e395b2609e020bb8b", - "from": "@bigcommerce/node-sass@git://github.com/bigcommerce-labs/node-sass.git#4ea0b8d5f7c418d5bf20b07e395b2609e020bb8b", + "version": "git://github.com/bigcommerce-labs/node-sass.git#4d39efa672f6df16d3b88627658eb1cf3076c1e1", + "from": "git://github.com/bigcommerce-labs/node-sass.git#v3.5.0", "requires": { "async-foreach": "^0.1.3", "chalk": "^1.1.1", @@ -128,11 +128,11 @@ } }, "@bigcommerce/stencil-styles": { - "version": "1.1.0", - "resolved": "https://registry.npmjs.org/@bigcommerce/stencil-styles/-/stencil-styles-1.1.0.tgz", - "integrity": "sha512-HEZTrhLdX1Hh9GuIZ/kL7uGbydagHgZhndS7vTzxVISZhFTk8Lo9ZzFYrqzeITRtTytWWVYifsawUsenU4mFRA==", + "version": "1.2.0-rc1", + "resolved": "https://registry.npmjs.org/@bigcommerce/stencil-styles/-/stencil-styles-1.2.0-rc1.tgz", + "integrity": "sha512-m5SO/AxNSlB3Qjd849A30n2xB+8EoNzn1yrTV/Ti9EozC9AsYOIsMafiF5sS7dFeN979B7Fxfe8okHWy+f1TPA==", "requires": { - "@bigcommerce/node-sass": "git://github.com/bigcommerce-labs/node-sass.git#4ea0b8d5f7c418d5bf20b07e395b2609e020bb8b", + "@bigcommerce/node-sass": "git://github.com/bigcommerce-labs/node-sass.git#4d39efa672f6df16d3b88627658eb1cf3076c1e1", "autoprefixer": "^6.7.3", "lodash": "^3.10.1", "postcss": "^5.2.14" @@ -2797,9 +2797,9 @@ } }, "caniuse-db": { - "version": "1.0.30000939", - "resolved": "https://registry.npmjs.org/caniuse-db/-/caniuse-db-1.0.30000939.tgz", - "integrity": "sha512-nB5tLf3hOs+biXl1lhKjHRgNC0J1I7H52h/t1FP7qxARKKwpB0z+P/JewJLYAlxCBP/q7rxJzQzHHrQMl0viKg==" + "version": "1.0.30000999", + "resolved": "https://registry.npmjs.org/caniuse-db/-/caniuse-db-1.0.30000999.tgz", + "integrity": "sha512-NzRdDmSmg/kp+eNIE1FT+/aXsyGy0PPoAmSrRAR4kFFOs+P19csnJWx4OeIKo6sxurr4xzlsso3rO7SkK71SGw==" }, "capture-exit": { "version": "1.2.0", @@ -4726,9 +4726,9 @@ "integrity": "sha1-WQxhFWsK4vTwJVcyoViyZrxWsh0=" }, "electron-to-chromium": { - "version": "1.3.113", - "resolved": "https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.3.113.tgz", - "integrity": "sha512-De+lPAxEcpxvqPTyZAXELNpRZXABRxf+uL/rSykstQhzj/B0l1150G/ExIIxKc16lI89Hgz81J0BHAcbTqK49g==" + "version": "1.3.280", + "resolved": "https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.3.280.tgz", + "integrity": "sha512-qYWNMjKLEfQAWZF2Sarvo+ahigu0EArnpCFSoUuZJS3W5wIeVfeEvsgmT2mgIrieQkeQ0+xFmykK3nx2ezekPQ==" }, "emitter-steward": { "version": "1.0.0", @@ -8694,9 +8694,9 @@ } }, "gulp-sass": { - "version": "4.0.1", - "resolved": "https://registry.npmjs.org/gulp-sass/-/gulp-sass-4.0.1.tgz", - "integrity": "sha512-OMQEgWNggpog8Tc5v1MuI6eo+5iiPkVeLL76iBhDoEEScLUPfZlpvzmgTnLkpcqdrNodZxpz5qcv6mS2rulk3g==", + "version": "4.0.2", + "resolved": "https://registry.npmjs.org/gulp-sass/-/gulp-sass-4.0.2.tgz", + "integrity": "sha512-q8psj4+aDrblJMMtRxihNBdovfzGrXJp1l4JU0Sz4b/Mhsi2DPrKFYCGDwjIWRENs04ELVHxdOJQ7Vs98OFohg==", "dev": true, "requires": { "chalk": "^2.3.0", @@ -8765,9 +8765,9 @@ } }, "glob": { - "version": "7.1.3", - "resolved": "https://registry.npmjs.org/glob/-/glob-7.1.3.tgz", - "integrity": "sha512-vcfuiIxogLV4DlGBHIUOwI0IbrJ8HWPc4MU7HzviGeNho/UJDfi6B5p3sHeWIQ0KGIU0Jpxi5ZHxemQfLkkAwQ==", + "version": "7.1.4", + "resolved": "https://registry.npmjs.org/glob/-/glob-7.1.4.tgz", + "integrity": "sha512-hkLPepehmnKk41pUGm3sYxoFs/umurYfYJCerbXEyFIWcAzvpipAgVkBqqT9RBKMGjnq6kMuyYwha6csxbiM1A==", "dev": true, "requires": { "fs.realpath": "^1.0.0", @@ -8805,9 +8805,9 @@ } }, "lodash": { - "version": "4.17.11", - "resolved": "https://registry.npmjs.org/lodash/-/lodash-4.17.11.tgz", - "integrity": "sha512-cQKh8igo5QUhZ7lg38DYWAxMvjSAKG0A8wGSVimP07SIUEK2UO+arSRKbRZWtelMtN5V0Hkwh5ryOto/SshYIg==", + "version": "4.17.15", + "resolved": "https://registry.npmjs.org/lodash/-/lodash-4.17.15.tgz", + "integrity": "sha512-8xOcRHvCjnocdS5cpwXQXVzmmh5e5+saE2QGoeQmbKmRS6J3VQppPOIt0MnmE+4xlZoumy0GPG0D0MVIQbNA1A==", "dev": true }, "lodash.clonedeep": { @@ -8850,10 +8850,16 @@ "minimist": "0.0.8" } }, + "nan": { + "version": "2.14.0", + "resolved": "https://registry.npmjs.org/nan/-/nan-2.14.0.tgz", + "integrity": "sha512-INOFj37C7k3AfaNTtX8RhsTw7qRy7eLET14cROi9+5HAVbbHuIWUHEauBv5qT4Av2tWasiTY1Jw6puUNqRJXQg==", + "dev": true + }, "node-sass": { - "version": "4.11.0", - "resolved": "https://registry.npmjs.org/node-sass/-/node-sass-4.11.0.tgz", - "integrity": "sha512-bHUdHTphgQJZaF1LASx0kAviPH7sGlcyNhWade4eVIpFp6tsn7SV8xNMTbsQFpEV9VXpnwTTnNYlfsZXgGgmkA==", + "version": "4.12.0", + "resolved": "https://registry.npmjs.org/node-sass/-/node-sass-4.12.0.tgz", + "integrity": "sha512-A1Iv4oN+Iel6EPv77/HddXErL2a+gZ4uBeZUy+a8O35CFYTXhgA8MgLCWBtwpGZdCvTvQ9d+bQxX/QC36GDPpQ==", "dev": true, "requires": { "async-foreach": "^0.1.3", @@ -8863,12 +8869,10 @@ "get-stdin": "^4.0.1", "glob": "^7.0.3", "in-publish": "^2.0.0", - "lodash.assign": "^4.2.0", - "lodash.clonedeep": "^4.3.2", - "lodash.mergewith": "^4.6.0", + "lodash": "^4.17.11", "meow": "^3.7.0", "mkdirp": "^0.5.1", - "nan": "^2.10.0", + "nan": "^2.13.2", "node-gyp": "^3.8.0", "npmlog": "^4.0.0", "request": "^2.88.0", @@ -9283,6 +9287,17 @@ "hoek": "2.x.x", "joi": "6.x.x", "wreck": "5.x.x" + }, + "dependencies": { + "wreck": { + "version": "5.6.1", + "resolved": "https://registry.npmjs.org/wreck/-/wreck-5.6.1.tgz", + "integrity": "sha1-r/ADBAATiJ11YZtccYcN0qjdBpo=", + "requires": { + "boom": "2.x.x", + "hoek": "2.x.x" + } + } } }, "heavy": { @@ -9293,6 +9308,19 @@ "boom": "2.x.x", "hoek": "2.x.x", "joi": "5.x.x" + }, + "dependencies": { + "joi": { + "version": "5.1.0", + "resolved": "https://registry.npmjs.org/joi/-/joi-5.1.0.tgz", + "integrity": "sha1-FSrQfbjunGQBmX/1/SwSiWBwv1g=", + "requires": { + "hoek": "^2.2.x", + "isemail": "1.x.x", + "moment": "2.x.x", + "topo": "1.x.x" + } + } } }, "hoek": { @@ -13743,12 +13771,6 @@ "integrity": "sha1-+6HEUkwZ7ppfgTa0YJ8BfPTe1pI=", "dev": true }, - "lodash.assign": { - "version": "4.2.0", - "resolved": "https://registry.npmjs.org/lodash.assign/-/lodash.assign-4.2.0.tgz", - "integrity": "sha1-DZnzzNem0mHRm9rrkkUAXShYCOc=", - "dev": true - }, "lodash.capitalize": { "version": "4.2.1", "resolved": "https://registry.npmjs.org/lodash.capitalize/-/lodash.capitalize-4.2.1.tgz", @@ -13852,12 +13874,6 @@ "lodash.toplainobject": "^3.0.0" } }, - "lodash.mergewith": { - "version": "4.6.1", - "resolved": "https://registry.npmjs.org/lodash.mergewith/-/lodash.mergewith-4.6.1.tgz", - "integrity": "sha512-eWw5r+PYICtEBgrBE5hhlT6aAa75f411bgDz/ZL2KZqYV03USvucsxcHUIlGTDTECs1eunpI7HOV7U+WLDvNdQ==", - "dev": true - }, "lodash.omit": { "version": "3.1.0", "resolved": "https://registry.npmjs.org/lodash.omit/-/lodash.omit-3.1.0.tgz", @@ -20437,9 +20453,9 @@ }, "dependencies": { "glob": { - "version": "7.1.3", - "resolved": "https://registry.npmjs.org/glob/-/glob-7.1.3.tgz", - "integrity": "sha512-vcfuiIxogLV4DlGBHIUOwI0IbrJ8HWPc4MU7HzviGeNho/UJDfi6B5p3sHeWIQ0KGIU0Jpxi5ZHxemQfLkkAwQ==", + "version": "7.1.4", + "resolved": "https://registry.npmjs.org/glob/-/glob-7.1.4.tgz", + "integrity": "sha512-hkLPepehmnKk41pUGm3sYxoFs/umurYfYJCerbXEyFIWcAzvpipAgVkBqqT9RBKMGjnq6kMuyYwha6csxbiM1A==", "dev": true, "requires": { "fs.realpath": "^1.0.0", diff --git a/package.json b/package.json index ff50e235..d36c173e 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "description": "CLI tool to run BigCommerce Stores locally for theme development.", "main": "index.js", "engines": { - "node": ">= 8.0.0 <9.0.0" + "node": ">= 8.0.0 <11.0.0" }, "scripts": { "lint": "eslint .", @@ -38,7 +38,7 @@ "homepage": "https://github.com/bigcommerce/stencil-cli", "dependencies": { "@bigcommerce/stencil-paper": "^3.0.0-rc.24", - "@bigcommerce/stencil-styles": "1.1.0", + "@bigcommerce/stencil-styles": "1.2.0-rc1", "accept-language-parser": "^1.0.2", "archiver": "^0.14.4", "async": "^2.4.0", @@ -116,7 +116,7 @@ "gulp-git-streamed": "2.4.0", "gulp-if": "2.0.0", "gulp-prompt": "0.1.2", - "gulp-sass": "4.0.1", + "gulp-sass": "4.0.2", "gulp-sass-lint": "1.1.1", "gulp-util": "3.0.7", "husky": "^1.2.0",