Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): strf-10231 Mapped URLs do not use their respective templates: #1028

Conversation

bc-max
Copy link
Contributor

@bc-max bc-max commented Nov 16, 2022

What?

Mapped URLs do not use their respective templates from custom layouts.

Tickets / Documentation

Screenshots (if appropriate)

cornerstone – custom-signs-safety-signs html 2022-11-16 16-58-45

Test product 2022-11-16 16-59-19

cc @bigcommerce/storefront-team

…emplates:

- template path lookup refactored;
@bc-max bc-max self-assigned this Nov 16, 2022
@bc-max bc-max marked this pull request as ready for review November 16, 2022 15:05
@bc-max bc-max requested a review from jairo-bc November 16, 2022 15:05
@jairo-bc
Copy link
Contributor

@bc-max Is this relevant #1027 ?

@bc-max
Copy link
Contributor Author

bc-max commented Nov 16, 2022

@bc-max Is this relevant #1027 ?

@jairo-bc Yeah, it looks relative.

@bc-max bc-max merged commit 3066d30 into bigcommerce:master Dec 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

🎉 This PR is included in version 5.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants