fix(storefront): bctheme-1331 Incorrect handling of nested external templates with params #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-alexsaiannyi
force-pushed
the
bctheme-1331
branch
from
eea0476 to
4fedb4d
Compare
yurytut1993
approved these changes
Nov 21, 2022
|
@bc-alexsaiannyi looks good, please revert package-lock.json |
jairo-bc
approved these changes
Dec 7, 2022
…emplates with params
bc-alexsaiannyi
force-pushed
the
bctheme-1331
branch
from
4fedb4d to
184458d
Compare
|
🎉 This PR is included in version 5.3.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In case we re-use external templates in our UI library and these templates receive data via parameters we will face an issue that we 'loose' these data due to incorrect handling of parameters. This PR fixes issue with incorrect handling of external templates that contain parameters.
Tickets / Documentation
Screenshots (if appropriate)
Before Fix:
After Fix:
cc @bigcommerce/storefront-team