Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show channel IDs in channel prompt when starting dev server #1222

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

loganwoolf
Copy link
Contributor

What?

This simply shows the channel ID in the list of available channels when starting the server. Some themes may use the channel ID, so this smooths the experience of selecting the right channel.

Tickets / Documentation

None.

Screenshots (if appropriate)

Screenshot 2024-08-28 at 5 42 26 PM

cc @bigcommerce/storefront-team

Copy link
Contributor

@bc-max bc-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚 Works properly on MSF and non-MSF stores

LGTM! Good job 🎉

@bc-max bc-max merged commit ac55f21 into bigcommerce:master Aug 29, 2024
8 of 9 checks passed
@bc-max
Copy link
Contributor

bc-max commented Aug 29, 2024

Need to revert this and recreate a PR due to incorrect commit message preventing from semantic release creation.

bc-max added a commit that referenced this pull request Aug 29, 2024
bc-max added a commit that referenced this pull request Aug 29, 2024
…1223)

Revert "Show channel IDs in channel prompt when starting dev server (#1222)"

This reverts commit ac55f21.
Copy link
Contributor

🎉 This PR is included in version 8.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants