Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant namespace scoping #45

Open
tanaya-mankad opened this issue May 24, 2024 · 0 comments
Open

Remove redundant namespace scoping #45

tanaya-mankad opened this issue May 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@tanaya-mankad
Copy link
Contributor

When a namespace object is used inside its own namespace, it doesn't need a scoping prefix. e.g.

namespace ashrae205_ns
{
    void from_json(const nlohmann::json& j, LiquidComponent& x) \
    {
        a205_json_get<ashrae205_ns::LiquidConstituent>(j, *logger, "liquid_constituent", x.liquid_constituent, x.liquid_constituent_is_set, true);
    }
}

can just be

namespace ashrae205_ns
{
    void from_json(const nlohmann::json& j, LiquidComponent& x) \
    {
        a205_json_get<LiquidConstituent>(j, *logger, "liquid_constituent", x.liquid_constituent, x.liquid_constituent_is_set, true);
    }
}
@tanaya-mankad tanaya-mankad added the enhancement New feature or request label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant