Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit changelog of 2.0 version to note a BC break #52

Open
Nek- opened this issue Oct 15, 2019 · 0 comments
Open

Edit changelog of 2.0 version to note a BC break #52

Nek- opened this issue Oct 15, 2019 · 0 comments

Comments

@Nek-
Copy link

Nek- commented Oct 15, 2019

This MR #51 (and this commit e305841 ) fix a serious issue, but also break in some circumstances.

After discussion with @mcsky if we should rollback the change on v2.0 or simply notice it in the changelog, we decided that it's an actual fix and previous usages were wrong. A note about how to fix it should be added. And here is the "quick fix" for those getting errors after upgrade:

class SimpleBCDictionary extends SimpleDictionary
{
    public function getKeys()
    {
        return array_map('strval', array_keys($this->values));
    }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant