-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct a cast in winfsp_fuse #154
Conversation
@benrubson thank you for the PR. I will also have to rebuild FUSE for Cygwin for x64 and x86 (in In order for me to accept contributions to this project I require that you add your name and email address to the Contributors document: https://github.com/billziss-gh/winfsp/blob/master/Contributors.asciidoc This effectively signs the document, assigns joint copyright to your change and identifies you as a contributor. You only need to do this one time on your first contribution. Re: tests failing. This does not appear related to your changes. Unfortunately drives fail to mount in the alloted time in recent builds; this is not something that is related to your changes. |
Thank you Bill, document just filled-in 👍 |
Your PR has been merged. Thank you for your contribution :) |
A tiny one :) Thank you for merging 👍 |
Unfortunately this change does not allow me to build cygfuse. The issue is that Cygwin has a prototype for I am changing this to the following: static inline char *fsp_fuse_conv_to_win_path(const char *path)
{
void *cygwin_create_path(unsigned, const void *);
return (char *)cygwin_create_path(
0/*CCP_POSIX_TO_WIN_A*/ | 0x100/*CCP_RELATIVE*/,
path);
} Can you please verify that it allows you to compile EncFS without problems? |
Sorry for this :/ |
No problem. Thanks for testing. New commit in a few secs with all the changes included. |
Commit 1cab0f3 should address this. |
Correct a cast in winfsp_fuse
Hi,
This PR corrects the cast issue in winfsp_fuse.
Thank you 👍
Ben