Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore empty tx in GetDiffAccountsWithScope #442

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

keefel
Copy link
Contributor

@keefel keefel commented Oct 8, 2021

Signed-off-by: Keefe-Liu bianze.kernel@gmail.com

Description

Ignore empty transaction in GetDiffAccountsWithScope.

Rationale

The empty transaction is useless for user, ignore them to reduce iteration.

Example

Changes

Notable changes:

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • manual transaction test passed

Already reviewed by

...

Related issues

... reference related issue #'s here ...

Signed-off-by: Keefe-Liu <bianze.kernel@gmail.com>
@keefel keefel merged commit 59d3b53 into bnb-chain:develop Oct 11, 2021
This was referenced Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants