[R4R]fix prefetcher related bugs #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Nov 1, 2021
core/block_validator.go
Outdated
| @@ -144,13 +144,15 @@ func (v *BlockValidator) ValidateState(block *types.Block, statedb *state.StateD | |||
| validateRes <- tmpFunc() | |||
| }() | |||
| } | |||
|
|
|||
| var err error = nil | |||
unclezoro
changed the title
Signed-off-by: Keefe-Liu <bianze.kernel@gmail.com>
Signed-off-by: Keefe-Liu <bianze.kernel@gmail.com>
yutianwu
approved these changes
Nov 1, 2021
unclezoro
approved these changes
Nov 1, 2021
This was referenced Nov 2, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.Fix panic in trie_prefetcher close
2.Fix trie_prefetcher abortLoop goroutine leak
Rationale
1.In ValidateState, there are three goroutines running concurrently, if the previous one return error, the upper caller function InsertChain would return and call it's defer function to close prefetcher, while the IntermediateRoot goroutine still run and when it done call its defer function to close prefetcher, this time the prefetcher is nil, so it will trigger a panic. So we should wait all the goroutines done in ValidateState to avoid this panic.
2.In InsertChain, if we enable diffsync, and insert two more blocks here, then all the blocks except the last one wound't do call StopPrefetcher, so these blocks' abortLoop goroutine will leak. So we should do the StopPrefetcher in IntermediateRoot to avoid this leak.
Example
add an example CLI or API response...
Changes
Notable changes:
Preflight checks
make build)make test)Already reviewed by
...
Related issues
#477