Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWScoringSheet, OWScoringSheetViewer: Add Widgets #264

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

ZanMervic
Copy link
Contributor

Issue
Description of changes

Added two new widgets designed for the Orange Explain addon: OWScoringSheet, OWScoringSheetViewer

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

Attention: 745 lines in your changes are missing coverage. Please review.

Comparison is base (fa634fa) 41.79% compared to head (c6647ce) 47.23%.

Files Patch % Lines
...rib/prototypes/modeling/fasterrisk/score_visual.py 0.00% 293 Missing ⚠️
...econtrib/prototypes/modeling/fasterrisk/wrapper.py 0.00% 151 Missing ⚠️
...rototypes/modeling/fasterrisk/binarization_util.py 0.00% 112 Missing ⚠️
...contrib/prototypes/widgets/owscoringsheetviewer.py 79.12% 62 Missing ⚠️
...ntrib/prototypes/modeling/fasterrisk/fasterrisk.py 59.85% 55 Missing ⚠️
...ngecontrib/prototypes/modeling/fasterrisk/utils.py 60.00% 34 Missing ⚠️
...ntrib/prototypes/modeling/fasterrisk/base_model.py 79.31% 18 Missing ⚠️
orangecontrib/prototypes/modeling/scoringsheet.py 80.35% 11 Missing ⚠️
...contrib/prototypes/modeling/fasterrisk/rounding.py 96.26% 4 Missing ⚠️
orangecontrib/prototypes/widgets/owscoringsheet.py 96.59% 3 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   41.79%   47.23%   +5.43%     
==========================================
  Files          12       24      +12     
  Lines        1670     3252    +1582     
==========================================
+ Hits          698     1536     +838     
- Misses        972     1716     +744     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markotoplak
Copy link
Member

fasterrisk's dependencies are too strict:

install_requires = \
['numpy>=1.23.3,<2.0.0',
 'pandas==1.5.2',
 'requests>=2.28.1,<3.0.0',
 'scikit-learn==1.2.0']

The problems are pandas and scikit-learn. Thus, this is conflicting with Orange. We can either:

  1. Convince the maintainer to open them up or
  2. Since the code is BSD, we can just put them in our repo (with the proper copyright).

I strongly prefer the first option, but if we are in a rush we'll need to do the second.

@markotoplak markotoplak merged commit b115c17 into biolab:master Nov 29, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants