Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scatter Plot: "No data on input" signal summary #5834

Closed
mw25 opened this issue Feb 8, 2022 · 2 comments · Fixed by #5836
Closed

Scatter Plot: "No data on input" signal summary #5834

mw25 opened this issue Feb 8, 2022 · 2 comments · Fixed by #5836
Assignees
Labels
bug A bug confirmed by the core team

Comments

@mw25
Copy link
Contributor

mw25 commented Feb 8, 2022

What's wrong?
Scatter Plot doesn't show the correct input signal summary. It always says "No data on input":
image

How can we reproduce the problem?

See screenshot.
Error is independent of whether the data subset input is used or not.

What's your environment?

  • Operating system: Windows 10
  • Orange version: 3.32.0.dev
  • How you installed Orange: clone repository
@mw25 mw25 added the bug report Bug is reported by user, not yet confirmed by the core team label Feb 8, 2022
@VesnaT VesnaT self-assigned this Feb 9, 2022
@ajdapretnar ajdapretnar added bug A bug confirmed by the core team and removed bug report Bug is reported by user, not yet confirmed by the core team labels Feb 9, 2022
@VesnaT
Copy link
Contributor

VesnaT commented Feb 9, 2022

This stopped working in version 4.14.1 of orange-widget-base (e48b9c78).

It happens to all widgets that override set_data (could be any other handler) and invoke parents method within, e.g. SVM:

    def set_data(self, data):
        self.Warning.sparse_data.clear()
        super().set_data(data)
        if self.data and sp.issparse(self.data.X):
            self.Warning.sparse_data()

@janezd
Copy link
Contributor

janezd commented Feb 9, 2022

The problem is that widgets that override a handler must also redecorate it (in this case, with @Inputs.data). The test for this feature does it (biolab/orange-widget-base@fe176f7#diff-37fa07c738eae3e261e558e3f3eed3bcfb6be97674f74348daf50a8a4d2d0c0fR495), while OWScatteplotGraph does not.

Alternatively, the summarize wrapper could use some more advanced test for whether the method was overriden but not redecorated, but this could be more complicated (I suppose it would involve checking the mro) and prone to fail. I'd suggest we just add decorators where needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug confirmed by the core team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants