Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ Implement biome search output formatting #2462

Closed
Tracked by #2461
arendjr opened this issue Apr 15, 2024 · 4 comments · Fixed by #3258
Closed
Tracked by #2461

☂️ Implement biome search output formatting #2462

arendjr opened this issue Apr 15, 2024 · 4 comments · Fixed by #3258
Assignees
Labels
good first issue Good for newcomers S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@arendjr
Copy link
Contributor

arendjr commented Apr 15, 2024

Description

The biome search command will be functionally similar to git grep: Where git grep uses regular expressions to search through all files in a Git repository, biome search will use Grit patterns to search through all files in a Biome project.

This command will serve as a proof-of-concept for our Grit runtime.

Even though the engine for this command is not yet ready, we could already proceed implement the output formatter. It should be similar to how diagnostics are reported, where arbitrary TextRanges can be highlighted and diagnostics can be presented alongside them. Except for this command, the ranges will represent matches for a given pattern.

Note

If you're interested in working on this issue, please comment here and we can assign it to you.

@arendjr arendjr added good first issue Good for newcomers S-Help-wanted Status: you're familiar with the code base and want to help the project labels Apr 15, 2024
This was referenced Apr 15, 2024
@BackupMiles
Copy link
Contributor

Hi! Can this issue be assigned to me?

@arendjr
Copy link
Contributor Author

arendjr commented Apr 20, 2024

Of course!

Just keep in mind you’ll need to make a little bit of a “dummy data provider” that will generate the matches for the output to display. The rest of the biome search infrastructure is there, so you can probably find the TODOs where this can be implemented and go from there. Have you already looked into this? I’d be happy to give more detailed pointers as well.

@BackupMiles
Copy link
Contributor

I will definitely start from the TODOs then! Today I will dedicate the whole day to it, so I will definitely be asking lots of questions.
Would it be better to ask in here or Discord?

@arendjr
Copy link
Contributor Author

arendjr commented Apr 20, 2024

@BackupMiles Great! I’ve created a topic for it on Discord, biome search command under Development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants