Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add participants to Rhea import #167

Closed
cmungall opened this issue Jan 29, 2024 · 3 comments · Fixed by #168
Closed

Add participants to Rhea import #167

cmungall opened this issue Jan 29, 2024 · 3 comments · Fixed by #168

Comments

@cmungall
Copy link

Would be useful to have rhea->chebi edges

"participants" is struck out - was there a reason for this?

@cthoyt
Copy link
Member

cthoyt commented Jan 29, 2024

Not sure why I didn't do this, do you have anyone on your team who wants to make a PR?

@cmungall
Copy link
Author

@balhoff likely won't touch python but he can at least advise us on how to do this

Jim, the code is pretty straightforward here:
https://github.com/pyobo/pyobo/blob/main/src/pyobo/sources/rhea.py

Maybe you could feed us the right SPARQL to use.

w.r.t the modeling, I think we should be as truthful to the source as possible. In particular, I think we should have "left" and "right" relations (potentially adding these to RO even though this will cause consternation). I don't think we should roll up to has-participant as we do in GO. And I don't think we should try a complicated OWL union.

there is an argument for only putting the participants on the child nodes where direction is known, and using has-input and has-output

for stoi, I don't think we should have a complicated nested structure. I think putting stoi on as axiom annotations should be fine.

@balhoff
Copy link

balhoff commented Jan 29, 2024

Here's some SPARQL we use to create a somewhat simplified graph including the reaction participants: https://github.com/geneontology/go-ontology/blob/master/src/sparql/construct-rhea-reactions.sparql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants