Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent current value is displayed when submitting param change proposal #2644

Open
devinbileck opened this issue Apr 4, 2019 · 7 comments

Comments

@devinbileck
Copy link
Member

When submitting a proposal for changing a phase length, the current value shown is inconsistent with the value shown in the dashboard. There is a technical reason for this, but potentially confusing to the user. The last block is technically part of the phase but for the user we show it as a break and don't allow proposals as the next block for confirmation would be then outside of phase.

Submitting a param change proposal:
image

Governance dashboard:
image

@devinbileck
Copy link
Member Author

I am not sure if we should just adjust the displayed value to compensate, or should restructure how the durations are defined/implemented.

@ManfredKarrer
Copy link
Contributor

The domain representation of the durations must not change, it is only a UI thing. The last block in the phases where the use need to do a tx cannot be used as the tx will end for sure in the 1 block of the break.

@ripcurlx
Copy link
Contributor

ripcurlx commented Apr 8, 2019

The domain representation of the durations must not change, it is only a UI thing. The last block in the phases where the use need to do a tx cannot be used as the tx will end for sure in the 1 block of the break.

Maybe we should adapt the UI representation in the proposal field as well (e.g. Current value 4 blocks (3 blocks + 1 block locked for phase transition) ?

@devinbileck
Copy link
Member Author

That could work. As long as we can present it so it doesn't look too crowded?

@stale
Copy link

stale bot commented Jul 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@ManfredKarrer
Copy link
Contributor

@devinbileck I think that is fixed already, right?

@devinbileck
Copy link
Member Author

I have not confirmed, but I don't think this has been resolved yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants