Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trade Info Popup #3317

Closed
niyid opened this issue Sep 24, 2019 · 4 comments
Closed

Trade Info Popup #3317

niyid opened this issue Sep 24, 2019 · 4 comments

Comments

@niyid
Copy link
Contributor

niyid commented Sep 24, 2019

I have attached the trad info pop-up window below.

The sender and receiver altcoin information may be a bit confusing:

In the screenshot at the line titled BTC Buyer payment details I see Receiver's altcoin address

I think this should be Sender's BSQ address using a placeholder instead of the static altcoin text.

Also the BTC Seller payment details line should have Receiver's BSQ address.

Screenshot from 2019-09-24 02-32-41

@chimp1984
Copy link
Contributor

chimp1984 commented Nov 1, 2019

Yes, right in both aspects. Feel free to add a PR for fixing it.

@niyid
Copy link
Contributor Author

niyid commented Nov 1, 2019

Yes, right in both aspects. Feel free to add a PR for fixing it.

I have: with this Push Request

You just have to acknowledge.

@stale
Copy link

stale bot commented Jan 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Jan 30, 2020
@stale
Copy link

stale bot commented Feb 6, 2020

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants