Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging peer only updates one row instead of all affected rows before restart #4660

Closed
MarioIshac opened this issue Oct 16, 2020 · 2 comments · Fixed by #6348
Closed

Tagging peer only updates one row instead of all affected rows before restart #4660

MarioIshac opened this issue Oct 16, 2020 · 2 comments · Fixed by #6348

Comments

@MarioIshac
Copy link

MarioIshac commented Oct 16, 2020

Description

Tagging a peer only applies that tag to the selected row of that peer instead of all their rows, until a restart is done.

Version

1.3.9

Steps to reproduce

Tag an untagged peer who has multiple rows on the offer sheet.

Expected behaviour

All rows of this peer would update to reflect the new tag.

Actual behaviour

Only the selected row of this peer updates to reflect the new tag.

Screenshots

Before restarting:
before_restart

After restarting (now that all rows are reloaded):
after_restart

Device or machine

Ubuntu 20.04

Additional info

It's a very minor issue, but I can attempt to solve it as my first issue to get familiar with Bisq repository.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 16, 2020

Thanks for opening your first issue here!

Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.

@cd2357
Copy link
Contributor

cd2357 commented Oct 16, 2020

Until a restart is done -- or until the user navigates to another view and comes back. That triggers a "reload" / refresh of the view, which shows the tag on all the rows for that peer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants