-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let user enter human friendly time for locking up BSQ. Let Bisq handle the conversion to block time. #5306
Comments
This will also make it possible for those not in the tech/crypto community to use the lockup tool as long term investors. |
Able to elaborate on that? What confirmation page? ;o I've not gone through this process. |
The confirmation page is the dialog bisq shows you after a successful 'Send BTC' transaction. |
Requesting assignment. |
@wallclockbuilder no need to wait for assignment :) When you have the change ready, feel free to open a PR and link it to this issue. Let us know if you have any issues or face any roadblocks. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant. |
Description
Locking up BSQ with a human friendly time is not possible.
User is required to specify time in blocks.
Google does not show any time to block time converters.
User is forced to do it by hand. After multiple tries its apparent the human calculated time in blocks almost always never matches what Bisq comes up with.
Allowing the human to specify time in a format familiar to them, makes the process straightforward. No googling needed. Bisq handles the conversion from human time to block time.
Version
v1.5.9
Steps to reproduce
Try locking up some BSQ for any amount of time.
Expected behaviour
User enters human friendly time (Bisq displays the approximate time in blocks).
Actual behaviour
User has to enter
Unlock time in blocks
User has to calculate unlock time in blocks themselves and is likely to be wrong as it is not clear what algorithm bisq is using for the block time calculation
Bisq shows human friendly time on the confirmation screen AFTER locking up bsq. It should be on the lock page instead. Having this on the lock page would have prevented the human from going through so many headaches calculating it in the first place.
The text was updated successfully, but these errors were encountered: