Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user enter human friendly time for locking up BSQ. Let Bisq handle the conversion to block time. #5306

Closed
wallclockbuilder opened this issue Mar 15, 2021 · 8 comments

Comments

@wallclockbuilder
Copy link
Contributor

Description

Locking up BSQ with a human friendly time is not possible.
User is required to specify time in blocks.
Google does not show any time to block time converters.
User is forced to do it by hand. After multiple tries its apparent the human calculated time in blocks almost always never matches what Bisq comes up with.
Allowing the human to specify time in a format familiar to them, makes the process straightforward. No googling needed. Bisq handles the conversion from human time to block time.

Version

v1.5.9

Steps to reproduce

Try locking up some BSQ for any amount of time.

Expected behaviour

Expected - User enters human friendly time  Bisq displays the approximate time in blocks
User enters human friendly time (Bisq displays the approximate time in blocks).

Actual behaviour

Actual - user has to enter unlock time in blocks
User has to enter Unlock time in blocks

Actual - user has to calculate unlock time in blocks themselves and is likely to be wrong as it is not clear what algorithm bisq is using for the block time calculation
User has to calculate unlock time in blocks themselves and is likely to be wrong as it is not clear what algorithm bisq is using for the block time calculation

Actual - bisq shows human friendly time on the confirmation screen AFTER locking up bsq. It should be on the lock page
Bisq shows human friendly time on the confirmation screen AFTER locking up bsq. It should be on the lock page instead. Having this on the lock page would have prevented the human from going through so many headaches calculating it in the first place.

@wallclockbuilder
Copy link
Contributor Author

This will also make it possible for those not in the tech/crypto community to use the lockup tool as long term investors.

@wallclockbuilder
Copy link
Contributor Author

Apparently the formula is to multiply the number of days by 1440 and divide by 10
Apparently the formula for calculating time in blocks is to multiply the number of days by 1440 and divide by 10.
Took forever to figure out. Then I found out on the confirmation page Bisq could have done it for me this whole time.

@Conza88
Copy link

Conza88 commented Mar 15, 2021

Then I found out on the confirmation page Bisq could have done it for me this whole time.

Able to elaborate on that? What confirmation page? ;o
All your work is still valid though, yeah?

I've not gone through this process.

@wallclockbuilder
Copy link
Contributor Author

The confirmation page is the dialog bisq shows you after a successful 'Send BTC' transaction.

@wallclockbuilder
Copy link
Contributor Author

Requesting assignment.

@cd2357
Copy link
Contributor

cd2357 commented May 10, 2021

Requesting assignment.

@wallclockbuilder no need to wait for assignment :) When you have the change ready, feel free to open a PR and link it to this issue.

Let us know if you have any issues or face any roadblocks.

@stale
Copy link

stale bot commented Aug 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Aug 21, 2021
@stale
Copy link

stale bot commented Sep 6, 2021

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants