Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 43 #1216

Closed
alvasw opened this issue Jan 8, 2023 · 4 comments
Closed

For Cycle 43 #1216

alvasw opened this issue Jan 8, 2023 · 4 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@alvasw
Copy link

alvasw commented Jan 8, 2023

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 12121.21
  • USD requested: 8000
  • BSQ rate: 0.66 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 42 #1198

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
PR Review: Improve seednode monitoring dev bisq-network/bisq#6432
PR Review: User defined trade limit, Part II. dev bisq-network/bisq#6433
PR Review: Feature to zip logfiles to home directory. dev bisq-network/bisq#6440
PR Review: Apply code review suggestions to seednode changes dev bisq-network/bisq#6454
Fix broken Gradle Dependency Verification dev bisq-network/bisq#6441 The following artifacts failed verification:
  • javafx-base-16-linux.jar (org.openjfx:javafx-base:16) from repository MavenRepo
  • javafx-controls-16-linux.jar (org.openjfx:javafx-controls:16) from repository MavenRepo
  • javafx-fxml-16-linux.jar (org.openjfx:javafx-fxml:16) from repository MavenRepo
  • javafx-graphics-16-linux.jar (org.openjfx:javafx-graphics:16) from repository MavenRepo
  • protoc-3.19.1-linux-x86_64.exe (com.google.protobuf:protoc:3.19.1) from repository MavenRepo
  • protoc-gen-grpc-java-1.42.1-linux-x86_64.exe (io.grpc:protoc-gen-grpc-java:1.42.1) from repository MavenRepo
  • jackson-base-2.12.1.pom
  • protoc-3.19.1-windows-x86_64.exe
  • protoc-gen-grpc-java-1.42.1-windows-x86_64.exe
  • junit-bom-5.7.0.pom
  • javafx-base-16-win.jar
  • javafx-controls-16-win.jar
  • javafx-fxml-16-win.jar
  • javafx-graphics-16-win.jar
Reenable verbose dependency verification (failure report) dev bisq-network/bisq#6442 The built-in Gradle dependency verification XML writer does not find all our libraries for some unknown reason. I had to compute and add multiple hashes manually. It seems like it is OS related and the CI output helped to fix the problem. The console output makes it hard to fix issues because we cannot access the generated HTML file. This change reenables the verbose failure report.
Enforce gradle dependency verification dev bisq-network/bisq#6443 We had some issues with the Gradle Dependency Verification and nobody noticed it because it was not enforced by Gradle. Supply chain attack are sadly a real threat that should not be underestimated.
Update to Gradle 7.6 dev bisq-network/bisq#6446
Introduce Gradle Version Catalog dev bisq-network/bisq#6449 To simplify the build.gradle file, this change moves all version variables to Gradle's version catalog.
Gradle: Move protoc build-logic into its own build.gradle dev bisq-network/bisq#6462
Add IntelliJ IDEA 2022.2.4 Support dev bisq-network/bisq2#578
DmgImageMounter: Check if image mounted and always unmount image dev bisq-network/bisq2#579 This change checks whether the DMG image is already mounted and unmounts the image even if an exception gets thrown during the extraction. We check the exit code of the mount and unmount process too.
DmgImageExtraction: Delegate caching to Gradle dev bisq-network/bisq2#580 We can always overwrite the existing Electrum.app file and rely on Gradle to decide whether the existing file is the newest version.
Add ability to check whether a given onion service is online dev bisq-network/bisq2#581 When another peer connects to us over Tor the connecting peer can lie about its onion address. We can challenge the peer to sign a payload to proof that the connecting peer has the private key of the provided onion address. This change adds the ability to check whether the onion service is known to the Tor directory servers.
DmgExtraction: Fix mount and copy race condition dev bisq-network/bisq2#583 Sometimes the copy process starts before the dmg image is fully mounted.
CI: Update setup-java to v3.8.0 dev bisq-network/bisq2#584
JSON-RPC: Move primitive responses to its module dev bisq-network/bisq2#585
JSON-RPC: Support StringList and Void responses dev bisq-network/bisq2#586
JSON-RPC: Parse error code and message dev bisq-network/bisq2#587
Remove Morero and Lightning from Bisq 2 dev bisq-network/bisq2#590
ConfidentialMessage: Add version field dev bisq-network/bisq2#591
Gradle Plugin: Discard subprocess output streams dev bisq-network/bisq2#592 There have been issues (on macOS) in the past because the OS waited until we read its output streams which we never happened.
DmgExtractor: Increase copy timeout to two minutes dev bisq-network/bisq2#593
JSON-RPC: Handle invalid rpc credentials dev bisq-network/bisq2#594
Migrate Bitcoin Core and Elements Core to JSON-RPC lib dev bisq-network/bisq2#595
Json RPC: Increase timeouts to 1 minute dev bisq-network/bisq2#596
Gradle: Disable parallel execution dev bisq-network/bisq2#597
Used global instance for ConncetionFailureTests dev bisq-network/bisq2#598
Wallets: Remove jackson-databind dependency dev bisq-network/bisq2#599
DaemonProcess: Increase shutdown timeout to two minutes dev bisq-network/bisq2#600
Elements: Remove guava and jeromq dependencies dev bisq-network/bisq2#601
DaemonProcess: Add 2 minute timeout to regtest start dev bisq-network/bisq2#602
CI: Disable Wallet integration tests dev bisq-network/bisq2#603
Create network module for all network related modules dev bisq-network/bisq2#606
Implement Socks5SocketChannel dev bisq-network/bisq2#607 The Socks5SocketChannel uses Java's NIO APIs. This will help us to make all socket actions non-blocking (asynchronous).
Implement TorSocketChannel dev bisq-network/bisq2#609
Add ElectrumX Docker Support dev bisq-network/bisq2#615 Only few contributors know how to setup Bitcoin Core and ElectrumX. Many others had issues in the past. This change help all new contributors setup a local regtest environment with Docker. This is an experimental feature without any persistence.
Hide socket in NetworkEnvelopeSocket dev bisq-network/bisq2#618 The NetworkEnvelopeSocket handles ProtoBuf serialization and deserialization.
dev 8000 Total for items above.
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Jan 8, 2023
@MwithM MwithM added this to the Cycle 43 milestone Jan 8, 2023
@ripcurlx
Copy link
Contributor

As dev team lead I approve this compensation request for dev. Please submit your CR to the DAO for voting and post the TX id here afterwards. Thanks!

@alvasw
Copy link
Author

alvasw commented Jan 12, 2023

711a15c50e7402e151a165eb2e5ccd7410a59b9b18dc8967b246766739cee6fe

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Jan 21, 2023
@ghost
Copy link

ghost commented Jan 21, 2023

Issuance by Team:

team amount BSQ amount USD
dev 12121.21 8000.00

Total Issuance: 12121.21 BSQ (equivalent to: 8000.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Jan 21, 2023

Closed as accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

3 participants