-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For Cycle 8 #417
Comments
At first glance, this seems high given the impact and user-value of the changes. Is there a previous successful request that you used to model this one? Can you explain a bit more about the work involved and how to think about this from a DAO voter's point of view? |
Agree. Even most typo fixes have been in comments (at least here bisq-network/bisq@587b55d). All nice to have but 4820 BSQ is way too high IMO. |
Good morning, gentlemen. You are absolutely right. I somehow made the wrong calculation. I was supposed to use the exact logic as in #78, #106, #167 Basically, 10 BSQ per fix. I have fixed the amount requested. I have no recollection how the 4820 number came to be (sounds absurd to me too!) and thanks for pointing it out :) |
Thanks for pointing out the prior requests that were accepted with this amount. I can understand the need for user-facing documents to be edited like this. Having fewer typos and grammar mistakes gives off a more confident tone and may encourage more users to try out the software. But as a newcomer here, it still isn't clear to me why the project needs to sustain a 10 BSQ inflation for every comment that doesn't have perfect grammar or capitalization. This project will always have contributors that may not have English as their first language and it isn't productive to have code reviewers double-checking and polluting reviews with grammar checks. How should a DAO voter look at this type of work in the broader scope of user-value and decide that this is something that should be funded? If this is important, how expensive would it be to just automate the grammar checking every month and obviate this type of manual work? Lastly, as a nit, I'm not 100% sure the incubator projects are still funded so contributions to those repositories seem even less valuable. This is my first cycle with the project so these questions may seem a bit different than previous iterations. I'm trying to get caught up with how delivery and value fit in with different types of requests. Happy to hear your thoughts. Thanks. |
For the translations the rates are: 0.07BSQ per word. For the review it is 0.035BSQ per word. As I can see you request 10BSQ for fixing a typo, so it is equivalent to translating 142 words in a foreign language... I agree fixing typos is good, but the rate seems way too high for me, at least 10 times. I am new here and just started to look at compensation requests, just trying to help finding a fair rate :) |
I agree with @trigger67 this still seems very high. I would like to kick of a discussion around that topic. At the moment trade volume is very low and with that burned BSQ. I think in such times we should be more conservative with expenses to not inflate the BSQ value too much. That does not mean that we should not invest in important work which helps us to increase trade volume, but I do not see clearly how the roughly 10 000 BSQ which is currently visible for requests in that area will translate into trade volume growth which justifies those costs. |
Yes, drastically. As noted above, the biggest item here is bisq-network/bisq#3643, which seems like mostly code comments to me. In my opinion this is the least valuable form of correction. The rest are relatively small, combined. I'm not sure why the previous typo compensation requests from rex4539 were accepted at 10 BSQ/typo, but I'm surprised they were.
There is no coordinated effort but we're trying to do something of the sort. arunasurya is working on determining criteria for adding languages, and @julianknutsen started discussion on tracking expenses after each cycle to evaluate return on investment. I tend to encourage and discourage efforts across my own domains (website, docs, growth) based on a loose sense of how well the project is going. At this point, I'm not sure it makes sense to create another position for coordinating these activities. I think it's sufficient for the main "managers" in each area to have periodical discussions to determine how much leeway there is for less-critical items, and then merge accordingly (growth, translations, documentation, website, etc). This case is a bit strange because it doesn't really fall under the purview of any particular function, so I'm not sure any amount of coordination would have helped...but fixing typos shouldn't ever be this big of a line-item either. |
I am open to discussing this further. Perhaps we can start by determining how much major projects cost, what fraction of the total cost they are, and set aside a certain budget for projects depending on their usefulness, which can be adjusted whenever demand for it changes. For the Transifex project, the costs are compensation requests for translators and admins which I can start keeping track of monthly. We are also planning to track YouTube views and site visits in different languages to determine how useful the other two projects (website and subtitles) are. I think maybe it is a good idea to have the bare minimum budget for basic translation and admin work that can be available at all times and then set aside resources for expanding into new markets when we have more revenue. |
The whole project needs some kind of mechanism for establishing and tracking budgeting and priorities. I should have a proposal out before the end of the week. |
Compensation was rejected by DAO. Kept open a few days for discussion. |
Closed as rejected. |
Summary
Contributions delivered
bisq-network/bisq#3643 (162 fixes in 87 files)
bisq-network/bisq#3647 (14 fixes in 10 files)
bisq-network/bisq#3659 (8 fixes in 1 file)
bisq-network/bisq#3637 (8 fixes in 5 files)
bisq-network/incubator-bisq-xmr-integration#2 (9 fixes in 6 files)
bisq-network/bisq-docs#179 (4 fixes in 2 files)
bisq-network/bisq-website#289 (2 fixes in 2 files)
Contributions in progress
bisq-network/incubator-bisq-api#21 (pending merge)
The text was updated successfully, but these errors were encountered: