Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address book page window (receiving or sending) should display the wallet name on its title #756

Closed
1 task done
pablomartin4btc opened this issue Sep 13, 2023 · 1 comment · Fixed by #757
Closed
1 task done

Address book page window (receiving or sending) should display the wallet name on its title #756

pablomartin4btc opened this issue Sep 13, 2023 · 1 comment · Fixed by #757

Comments

@pablomartin4btc
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current behaviour

At the moment, when a user has multiple wallets loaded and switches between them while opening the Address Book manager to check or copy "Sending" or "Receiving" addresses, it's not clear which addresses belong to which wallet.

image

Expected behaviour

Similar to the main window, I think the address book page window should point out to which wallet those addresses belong to.

Steps to reproduce

  1. Launch the bitcoin-qt application on any network.
  2. Ensure you have at least two wallets loaded. If needed, create additional wallets.
  3. Open the "Receiving addresses" (or "Sending...") window from the "Windows" menu at the top.
  4. Select a different wallet from the combo-box labeled "Wallet:" in the main application window.
  5. Once again, go to the "Windows" menu and select "Receiving addresses" (or "Sending..." depends on step 3).

This sequence of steps will open separate "Receiving addresses" (or "Sending...", depends on steps 3 & 5) windows with distinct lists of addresses. To create "receiving addresses," click the "Receive" button located under the main menu at the top, which will open the receive coins dialog.

Relevant log output

No response

How did you obtain Bitcoin Core

Compiled from source

What version of Bitcoin Core are you using?

v25.99

Operating system and version

Ubuntu 22.04

Machine specifications

No response
@pablomartin4btc pablomartin4btc mentioned this issue Sep 13, 2023
Merged
@jarolrod
Copy link
Member

Concept ACK, This can be useful, removing any possible confusion

@hebasto hebasto closed this as completed in 8369467 Oct 4, 2023
Frank-GER pushed a commit to syscoin/syscoin that referenced this issue Oct 13, 2023
@hebasto
Merge bitcoin-core/gui#757: Add wallet name to address book page title
8c44b4f 
58c9b50 gui: Add wallet name to address book page (pablomartin4btc)

Pull request description:

  It fixes bitcoin-core/gui#756.

  Each address book page window it's now labeled with the wallet name they were opened with, so the user can easily identify which addresses belong to which wallet even when there are many windows opened. It's a helpful enhancement for users managing multiple wallets.

  ![image](https://github.com/bitcoin-core/gui/assets/110166421/628e37bb-87b9-42fb-9158-bffdd8428bcb)

ACKs for top commit:
  hebasto:
    ACK 58c9b50, tested on Ubuntu 22.04.

Tree-SHA512: 82febc020653560281da144cd35c672c49ca9f48b23d173eb19395e9ab4d045500295a9b5f24c82efdbf6e7ea70c87e733207cb6a31d3f84828b27e3b2df558b
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add wallet name to address book page title pablomartin4btc/bitcoin-core-gui
2 participants
@jarolrod @pablomartin4btc