Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display plain "Inbound" in peer details #203

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Display plain "Inbound" in peer details #203

merged 1 commit into from
Feb 5, 2021

Conversation

jonatack
Copy link
Member

@jonatack jonatack commented Jan 30, 2021 •
edited
Loading

Alternative version to #201.

This was referenced Jan 30, 2021
Closed
Merged
maflcko
maflcko approved these changes Jan 30, 2021
View reviewed changes
Copy link
Contributor

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review ACK ff8afeb

Thanks

doc/release-notes-162-163.md Outdated Show resolved Hide resolved
@jonatack jonatack changed the title gui: display plain "Inbound" in peer details, add #162/#163 release notes gui: display plain "Inbound" in peer details Jan 30, 2021
@jonatack jonatack force-pushed the display-plain-inbound-and-add-release-notes branch from ff8afeb to 506e658 Compare January 30, 2021 19:29
@jonatack jonatack changed the title gui: display plain "Inbound" in peer details Display plain "Inbound" in peer details Jan 30, 2021
@hebasto
Copy link
Member

hebasto commented Jan 30, 2021

Alternative version to #201.

Concept ACK, but #201 still preferred to me, tbh.

@maflcko
Copy link
Contributor

maflcko commented Jan 31, 2021

ACK 506e658

@jonatack
Copy link
Member Author

jonatack commented Feb 5, 2021

-netinfo on master is now aligned with this change:

Screenshot from 2021-02-05 17-14-34

jonasschnelli
jonasschnelli approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@jonasschnelli jonasschnelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 506e658

@jonasschnelli jonasschnelli merged commit 6c61408 into bitcoin-core:master Feb 5, 2021
@jonatack jonatack deleted the display-plain-inbound-and-add-release-notes branch February 5, 2021 17:53
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Feb 5, 2021
@jonasschnelli
Merge bitcoin-core/gui#203: Display plain "Inbound" in peer details
8fb2f17 
506e658 gui: display plain "Inbound" in peer details (Jon Atack)

Pull request description:

  Alternative version to #201.

ACKs for top commit:
  MarcoFalke:
    ACK 506e658
  jonasschnelli:
    utACK 506e658

Tree-SHA512: 88d141b14684c1dcdff47f7ba241e5a7c42c14da3d9aaa89f1649235a64fd26bc5a6055707dc07992cd9d8c05d143754f6dd51ccee69fd4309336dd07c52e61c
lehuuhieu7777
lehuuhieu7777 reviewed Feb 6, 2021
View reviewed changes
Copy link

@lehuuhieu7777 lehuuhieu7777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ldenman

@jonatack jonatack mentioned this pull request Feb 6, 2021
Merged
@hebasto hebasto mentioned this pull request Aug 8, 2021
Closed
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lehuuhieu7777 lehuuhieu7777 lehuuhieu7777 left review comments

@maflcko maflcko maflcko approved these changes

@jonasschnelli jonasschnelli jonasschnelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonatack @hebasto @maflcko @jonasschnelli @lehuuhieu7777