Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNI binding potential memory issue #608

Closed
ghost opened this issue Apr 9, 2019 · 0 comments · Fixed by #682
Closed

JNI binding potential memory issue #608

ghost opened this issue Apr 9, 2019 · 0 comments · Fixed by #682

Comments

@ghost
Copy link

ghost commented Apr 9, 2019

https://github.com/bitcoin-core/secp256k1/blob/master/src/java/org/bitcoin/NativeSecp256k1.java#L87

when passing the secret key the bytebuffer is never cleared and replaced with zeros. the secret key could potentially be in memory. during that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants