Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create symbol to get the version of this library #909

Open
rickmark opened this issue Mar 24, 2021 · 2 comments
Open

Create symbol to get the version of this library #909

rickmark opened this issue Mar 24, 2021 · 2 comments
Labels

Comments

@rickmark
Copy link

As the library approaches 1.0 we should provide a symbol to ask for the version of libsecp256k1

An example such as what is provided by OpenSSL - https://www.openssl.org/docs/man1.1.0/man3/OPENSSL_VERSION_NUMBER.html

Before the 1.0 release candidate series this can use a value of 0.8 or 0.9 to reflect the non-stable API surface

@rickmark
Copy link
Author

Created #914 for this

@real-or-random
Copy link
Contributor

What exactly would you need this for? Some more rationale will help. I guess OpenSSL does that for a reason, but our project is much simpler.

I don't think there's a strong reason not to do this, but maybe what you actually want is some kind of ABI version? Or an assert_version function instead of a get_version function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants