Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilization of schnorrsig #992

Closed
real-or-random opened this issue Oct 19, 2021 · 2 comments · Fixed by #995
Closed

Stabilization of schnorrsig #992

real-or-random opened this issue Oct 19, 2021 · 2 comments · Fixed by #995

Comments

@real-or-random
Copy link
Contributor

Beyond those two, the only remaining experimental feature is the recently-merged BIP340 support. It is experimental for two reasons:

  • There are a few discussions still ongoing that may impact the API (variable-length message support, batch validation) without changes to the (currently supported) part of the scheme. It's not impossible to just add new functions for these once they're worked out, but given the next point, I think this may not be needed.
  • It's very hard to be sure what exact semantics of BIP340 will actually activate on Bitcoin (or if it will at all), and if that ends up being different from what is implemented now, eventually this library will want to implement the final scheme. I think changes are very unlikely at this point, but it's also not exactly under our control.

Originally posted by @sipa in #817 (comment)

@real-or-random
Copy link
Contributor Author

The second point is clearly resolved, so is there anything that prevents us from marking schnorrsig as non-experimental?

@jonasnick
Copy link
Contributor

Not that I know. We have variable-length message support now, sign_custom is extensible in a backward compatible manner and current ideas for bach validation would not change the existing API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants