Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add icons package #8

Merged
merged 4 commits into from
Aug 12, 2024
Merged

feat: add icons package #8

merged 4 commits into from
Aug 12, 2024

Conversation

Emmanuel-Develops
Copy link
Collaborator

Add icons to the library.

To be used as

import { GitHubIcon, SearchIcon } from 'bdp-ui/icons';

Copy link
Collaborator

@IgboPharaoh IgboPharaoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, just a few comments

src/icons/TimeIcon.tsx Outdated Show resolved Hide resolved
src/icons/FilterCloseIcon.tsx Outdated Show resolved Hide resolved
@Emmanuel-Develops Emmanuel-Develops force-pushed the icon-package branch 2 times, most recently from 6de4511 to f341071 Compare August 9, 2024 13:58
@Emmanuel-Develops
Copy link
Collaborator Author

Storybook preview to view all Icons

Screenshot 2024-08-09 at 2 58 38 PM

@Extheoisah Extheoisah merged commit 1a8872a into main Aug 12, 2024
Copy link

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Extheoisah Extheoisah deleted the icon-package branch August 14, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants