Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing full stop from log lines #134

Open
sr-gi opened this issue Oct 10, 2023 · 3 comments
Open

Remove trailing full stop from log lines #134

sr-gi opened this issue Oct 10, 2023 · 3 comments
Labels
feature New feature or request good first issue Good for newcomers Low Priority nit Small nitpicks that are picked up in testing.

Comments

@sr-gi
Copy link
Member

sr-gi commented Oct 10, 2023

Describe desired feature

This is pretty opinionated, but I think log lines should not end in full stop

Use case for feature

Being able to copy info from the terminal without carrying over the full stop. Right now, if you try to copy data from the terminal by double-clicking on it to select it (such as node ids, hashes, ...) the full stop will be carried over. Here are some examples:

> 2023-10-10T15:50:09.139Z INFO [sim_cli] Connected to alice - Node ID: 02c7e2f01ea946252b29a2e24629d67df3740f3db448ec42a1bccb52e2b7482b2a.

02c7e2f01ea946252b29a2e24629d67df3740f3db448ec42a1bccb52e2b7482b2a.

> 2023-10-10T15:50:15.195Z DEBUG [sim_lib] Tracking payment outcome for: 6fd79189307a9db7e685c0ffcd909d46a5a25f2cb736753080e7092d856ab47a.

6fd79189307a9db7e685c0ffcd909d46a5a25f2cb736753080e7092d856ab47a.

Would you like to contribute code for this feature?

Sure, if we reach consensus about it

@sr-gi sr-gi added feature New feature or request good first issue Good for newcomers nit Small nitpicks that are picked up in testing. Low Priority labels Oct 10, 2023
@sr-gi sr-gi changed the title Feature Request Remove trailing full stop from log lines Oct 10, 2023
@carlaKC carlaKC added this to the V1 Minor Improvements milestone Oct 11, 2023
@ikeogu
Copy link

ikeogu commented Mar 2, 2024

I will love to contribute to resolve this.

@carlaKC
Copy link
Contributor

carlaKC commented Mar 2, 2024

I will love to contribute to resolve this.

I'm fine with doing one full sweep to update this, it is an aesthetic change that's going to cause a ton of rebase conflicts. We've got some big PRs in flight at the moment, so:

  1. Feel free to open, but expect to rebase a lot yourself because they'll take merge precedence
  2. Hold off till a quieter time (I'll try remember to ping on the issue when I think the moment is right)

@ikeogu
Copy link

ikeogu commented Mar 2, 2024

Alright! thank you @carlaKC for your feedback, I'll wait much later time for this.
Let me hunt for another issue to resolve, I just want to contribute.

@carlaKC carlaKC removed this from the V1 Minor Improvements milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers Low Priority nit Small nitpicks that are picked up in testing.
Projects
None yet
Development

No branches or pull requests

3 participants