Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out how to handle unknown messages in DLCConnectionHandler #3468

Open
benthecarman opened this issue Aug 2, 2021 · 1 comment
Open

Figure out how to handle unknown messages in DLCConnectionHandler #3468

benthecarman opened this issue Aug 2, 2021 · 1 comment
Labels
dlc-node

Comments

@benthecarman
Copy link
Collaborator

For the Node we are able to handle unknown bitcoin p2p messages because we have the message length. For the DLCNode we are using a LnMessage which doesn't have a message length associated with it. We either need to switch to using TLVs or figure out a way to handle unknown messages.

#3402 (comment)
@benthecarman
Copy link
Collaborator Author

Implementing this may be a solution

discreetlogcontracts/dlcspecs#171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dlc-node
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benthecarman