Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-789): extend PIKE capability #91

Merged
merged 6 commits into from
May 24, 2024

Conversation

pawellewandowski98
Copy link
Contributor

@pawellewandowski98 pawellewandowski98 commented May 20, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

Description

  • Added extended PIKE capability
  • Added option to create nested capabilities
  • Split PIKE services for contact and payment, it allows us to use only one feature from PIKE (and disable invitation)

Example of capabilities:

{
    "bsvalias": "1.0",
    "capabilities": {
        "2a40af698840": "https://pawel.4chain.space/v1/bsvalias/p2p-payment-destination/{alias}@{domain.tld}",
        "5c55a7fdb7bb": "https://pawel.4chain.space/v1/bsvalias/beef/{alias}@{domain.tld}",
        "5f1323cddf31": "https://pawel.4chain.space/v1/bsvalias/receive-transaction/{alias}@{domain.tld}",
        "6745385c3fc0": false,
        "8c4ed5ef8ace": "https://pawel.4chain.space/v1/bsvalias/pike/{alias}@{domain.tld}",
       ///////    NEW CAPABILITY
        "935478af7bf2": {
            "invite": "https://pawel.4chain.space/v1/bsvalias/contact/invite/{alias}@{domain.tld}",
            "outputs": "https://pawel.4chain.space/v1/bsvalias/pike/outputs/{alias}@{domain.tld}"
        },
       /////// 
        "a9f510c16bde": "https://pawel.4chain.space/v1/bsvalias/verify-pubkey/{alias}@{domain.tld}/{pubkey}",
        "f12f968c92d6": "https://pawel.4chain.space/v1/bsvalias/public-profile/{alias}@{domain.tld}",
        "paymentDestination": "https://pawel.4chain.space/v1/bsvalias/address/{alias}@{domain.tld}",
        "pki": "https://pawel.4chain.space/v1/bsvalias/id/{alias}@{domain.tld}"
    }
}

NOTE: for now old PIKE capability is also enabled for backward capability

@pawellewandowski98 pawellewandowski98 self-assigned this May 20, 2024
Copy link

github-actions bot commented May 20, 2024

Manual Tests

πŸ’š Manual testing by @wregulski resulted in success.

@pawellewandowski98 pawellewandowski98 requested a review from a team May 20, 2024 13:00
brfc_definintions.go Show resolved Hide resolved
pike.go Outdated Show resolved Hide resolved
server/capabilities.go Outdated Show resolved Hide resolved
server/payment.go Show resolved Hide resolved
server/payment.go Outdated Show resolved Hide resolved
server/payment.go Outdated Show resolved Hide resolved
server/pike.go Show resolved Hide resolved
@wregulski
Copy link
Contributor

testing

@wregulski wregulski added the tested PR was tested by a team member label May 24, 2024
@pawellewandowski98 pawellewandowski98 merged commit 6b1a07c into main May 24, 2024
3 checks passed
@pawellewandowski98 pawellewandowski98 deleted the feat-789-extend-PIKE-capability branch May 24, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants