From b4b7c4a8c7f6830a15b0de1c6e33a948735f6a43 Mon Sep 17 00:00:00 2001 From: vitalibalashka Date: Fri, 29 Sep 2023 10:24:26 +0200 Subject: [PATCH] feat: delete ExecuteSimplifiedPaymentVerification from PaymailServiceProvider --- examples/server/run_server/demo_interface.go | 7 ------- server/interface.go | 5 ----- server/mock_test.go | 7 ------- server/p2p_receive_transaction.go | 2 +- server/simple_payment_verification.go | 14 ++++++++++++++ 5 files changed, 15 insertions(+), 20 deletions(-) create mode 100644 server/simple_payment_verification.go diff --git a/examples/server/run_server/demo_interface.go b/examples/server/run_server/demo_interface.go index 750a691..675e159 100644 --- a/examples/server/run_server/demo_interface.go +++ b/examples/server/run_server/demo_interface.go @@ -43,10 +43,3 @@ func (d *demoServiceProvider) RecordTransaction(ctx context.Context, // Record the tx into your datastore layer return DemoRecordTransaction(ctx, p2pTx) } - -// ExecuteSimplifiedPaymentVerification is a demo implementation of this interface -func (d *demoServiceProvider) ExecuteSimplifiedPaymentVerification(ctx context.Context, - beedData *paymail.DecodedBEEF) error { - - return nil -} diff --git a/server/interface.go b/server/interface.go index 6cde220..4f489bc 100644 --- a/server/interface.go +++ b/server/interface.go @@ -33,9 +33,4 @@ type PaymailServiceProvider interface { p2pTx *paymail.P2PTransaction, metaData *RequestMetadata, ) (*paymail.P2PTransactionPayload, error) - - ExecuteSimplifiedPaymentVerification( - ctx context.Context, - beedData *paymail.DecodedBEEF, - ) error } diff --git a/server/mock_test.go b/server/mock_test.go index ed0ddef..f4e73c9 100644 --- a/server/mock_test.go +++ b/server/mock_test.go @@ -40,10 +40,3 @@ func (m *mockServiceProvider) RecordTransaction(_ context.Context, // Record the tx into your datastore layer return nil, nil } - -// ExecuteSimplifiedPaymentVerification is a mock implementation of this interface -func (m *mockServiceProvider) ExecuteSimplifiedPaymentVerification(ctx context.Context, - beedData *paymail.DecodedBEEF) error { - - return nil -} diff --git a/server/p2p_receive_transaction.go b/server/p2p_receive_transaction.go index 88fa1b6..9dd7a7a 100644 --- a/server/p2p_receive_transaction.go +++ b/server/p2p_receive_transaction.go @@ -88,7 +88,7 @@ func (c *Configuration) p2pReceiveBeefTx(w http.ResponseWriter, req *http.Reques } var err error - if err = c.actions.ExecuteSimplifiedPaymentVerification(req.Context(), beefData); err != nil { + if err = ExecuteSimplifiedPaymentVerification(req.Context(), beefData); err != nil { ErrorResponse(w, ErrorSimplifiedPaymentVerification, err.Error(), http.StatusExpectationFailed) return } diff --git a/server/simple_payment_verification.go b/server/simple_payment_verification.go new file mode 100644 index 0000000..33a6361 --- /dev/null +++ b/server/simple_payment_verification.go @@ -0,0 +1,14 @@ +package server + +import ( + "context" + + "github.com/bitcoin-sv/go-paymail" +) + +// ExecuteSimplifiedPaymentVerification verifies the inbound transaction (SPV). +// At the moment there are no sufficient requirements for its implementation. +func ExecuteSimplifiedPaymentVerification(ctx context.Context, beedData *paymail.DecodedBEEF) error { + + return nil +}