From c7ba91700be64da4cd553448d5ff68d1c84180e4 Mon Sep 17 00:00:00 2001 From: Satchmo Date: Tue, 3 Sep 2024 14:10:51 -0400 Subject: [PATCH] use require instead of assert in tests, use require.Positive instead of Greater than 0 --- util/big_test.go | 2 +- util/bytemanipulation_test.go | 11 +++++------ util/bytestring_test.go | 21 ++++++++++----------- 3 files changed, 16 insertions(+), 18 deletions(-) diff --git a/util/big_test.go b/util/big_test.go index ba840c5..70651d8 100644 --- a/util/big_test.go +++ b/util/big_test.go @@ -65,7 +65,7 @@ func TestNewRandomBigInt(t *testing.T) { b := util.NewRandomBigInt(tc.byteLen) require.NotNil(t, b) require.LessOrEqual(t, len(b.Bytes()), tc.byteLen) - require.Greater(t, b.BitLen(), 0) + require.Positive(t, b.BitLen()) }) } } diff --git a/util/bytemanipulation_test.go b/util/bytemanipulation_test.go index dc90b6b..5d1497c 100644 --- a/util/bytemanipulation_test.go +++ b/util/bytemanipulation_test.go @@ -5,7 +5,6 @@ import ( "testing" crypto "github.com/bitcoin-sv/go-sdk/primitives/hash" - "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" "github.com/bitcoin-sv/go-sdk/util" @@ -63,7 +62,7 @@ func TestLittleEndianBytes(t *testing.T) { t.Run(tc.name, func(t *testing.T) { t.Parallel() result := util.LittleEndianBytes(tc.input, tc.length) - assert.Equal(t, tc.expected, result) + require.Equal(t, tc.expected, result) }) } } @@ -74,27 +73,27 @@ func TestReverseBytes(t *testing.T) { t.Run("Empty slice", func(t *testing.T) { input := []byte{} result := util.ReverseBytes(input) - assert.Equal(t, input, result) + require.Equal(t, input, result) }) t.Run("Single byte", func(t *testing.T) { input := []byte{0x01} result := util.ReverseBytes(input) - assert.Equal(t, input, result) + require.Equal(t, input, result) }) t.Run("Multiple bytes", func(t *testing.T) { input := []byte{0x01, 0x02, 0x03, 0x04} expected := []byte{0x04, 0x03, 0x02, 0x01} result := util.ReverseBytes(input) - assert.Equal(t, expected, result) + require.Equal(t, expected, result) }) t.Run("Odd number of bytes", func(t *testing.T) { input := []byte{0x01, 0x02, 0x03, 0x04, 0x05} expected := []byte{0x05, 0x04, 0x03, 0x02, 0x01} result := util.ReverseBytes(input) - assert.Equal(t, expected, result) + require.Equal(t, expected, result) }) t.Run("genesis hash", func(t *testing.T) { diff --git a/util/bytestring_test.go b/util/bytestring_test.go index c369ab9..ce19993 100644 --- a/util/bytestring_test.go +++ b/util/bytestring_test.go @@ -5,7 +5,6 @@ import ( "encoding/json" "testing" - "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" "github.com/bitcoin-sv/go-sdk/util" @@ -33,7 +32,7 @@ func TestNewByteStringFromHex(t *testing.T) { for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { result := util.NewByteStringFromHex(tt.input) - assert.Equal(t, tt.expected, result) + require.Equal(t, tt.expected, result) }) } } @@ -52,7 +51,7 @@ func TestByteStringMarshalJSON(t *testing.T) { t.Run(tt.name, func(t *testing.T) { result, err := json.Marshal(tt.input) require.NoError(t, err) - assert.Equal(t, tt.expected, string(result)) + require.Equal(t, tt.expected, string(result)) }) } } @@ -75,10 +74,10 @@ func TestByteStringUnmarshalJSON(t *testing.T) { var bs util.ByteString err := json.Unmarshal([]byte(tt.input), &bs) if tt.wantErr { - assert.Error(t, err) + require.Error(t, err) } else { - assert.NoError(t, err) - assert.Equal(t, tt.expected, bs) + require.NoError(t, err) + require.Equal(t, tt.expected, bs) } }) } @@ -97,7 +96,7 @@ func TestByteStringString(t *testing.T) { for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { result := tt.input.String() - assert.Equal(t, tt.expected, result) + require.Equal(t, tt.expected, result) }) } } @@ -116,7 +115,7 @@ func TestByteStringValue(t *testing.T) { t.Run(tt.name, func(t *testing.T) { result, err := tt.input.Value() require.NoError(t, err) - assert.Equal(t, tt.expected, result) + require.Equal(t, tt.expected, result) }) } } @@ -137,10 +136,10 @@ func TestByteStringScan(t *testing.T) { var bs util.ByteString err := bs.Scan(tt.input) if tt.wantErr { - assert.Error(t, err) + require.Error(t, err) } else { - assert.NoError(t, err) - assert.Equal(t, tt.expected, bs) + require.NoError(t, err) + require.Equal(t, tt.expected, bs) } }) }