Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: offline / multisig UX #16954

Closed
Sjors opened this issue Sep 24, 2019 · 4 comments
Closed

ui: offline / multisig UX #16954

Sjors opened this issue Sep 24, 2019 · 4 comments

Comments

@Sjors
Copy link
Member

Sjors commented Sep 24, 2019

Continued discussion from #16944 (comment), based on @gwillen's offline signing branch: https://github.com/gwillen/bitcoin/tree/feature-offline-v2

Schermafbeelding 2019-09-24 om 14 09 54

If we make the entire Send experience a modal, things might get a bit simpler.

IMG_4970

Sorry for the handwriting :-) There's 3 stages to a transaction:

  1. Draft / compose: enter recipient, amount, fees, etc. (the current Send screen).

This step is skipped when loading a PSBT (e.g. via menu: Transaction -> Load, or a smart clipboard).

  1. Sign: currently a popup which confirms the details. With hardware wallets (e.g. UI external signer support (e.g. hardware wallet) #16549) this should enumerate connected wallets and let you sign one by one. In a multisig situation it should detect if any signatures are missing, and rename the 3rd step to "Export".

  2. Finish / Export: once again repeat the importantant details. For basic wallets with private keys in it, this should just show that the transaction has been broadcast. With a completed PSBT it should let the user choose between broadcasting or exporting (clipboard, save to disk).

@Sjors
Copy link
Member Author

Sjors commented Sep 24, 2019

Some work in progress here to refactor the existing flow into this 3 step "wizard": https://github.com/Sjors/bitcoin/tree/2019/09/gui-send

@andronoob
Copy link

Might be off-topic, but as far as I know, Bitcoin Core currently generates privkeys through hardened derivation path, doesn't it? This seems to be an obstacle to watch-only wallet.

@jazzholicbae
Copy link

Would be great if we could support OP_CHECKLOCKTIMEVERIFY also ( like https://coinb.in/#newTimeLocked )

@fanquake
Copy link
Member

I've moved this over to the GUI repo: bitcoin-core/gui#56.

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants