gui: Node appears as Unroutable in peers list

[benthecarman]

This is using the bitcoin-s node, I am unsure if this is something wrong on our end, or on bitcoin core's end. Messages are able to be passed back and forth just fine. This is shown for the node running on the local computer and one on a separate computer.

[sipa]

This is expected, albeit confusing. It just means that node can't be reached from the internet (127.0.0.1 is a non-public IP).

[benthecarman]

This is expected, albeit confusing. It just means that node can't be reached from the internet (127.0.0.1 is a non-public IP).

How about for the Type? (This is a neutrino node)

[sipa]

What type?

[benthecarman]

What type?

[maflcko]

Incoming peers don't have a type (other than "incoming"). Is this elided? What version are you using?

[jonatack]

Right, inbound peers have a connection direction but not type yet, as we can't infer full relay or block relay status from fRelay / fRelayTxes (Wants Tx Relay in the GUI peer details area or RPC getpeerinfo relaytxes). Discussion here: bitcoin-core/gui#201. These changes were made in January and aren't in a release yet.

[benthecarman]

Incoming peers don't have a type (other than "incoming"). Is this elided? What version are you using?

This is on e7776e2

[maflcko]

Was this bug introduced in bitcoin-core/gui@6fc72bd ?

See also the tested ACKs, which show the empty string here: bitcoin-core/gui#179 (comment)

[jonatack]

What different behavior are you expecting?

[jonatack]

ISTM this is the expected behavior and the issue can be closed.

[maflcko]

I think the type shouldn't be empty string but "Inbound", no?

[jonatack]

We do the same with -netinfo after this topic was discussed in January; direction and type are different columns. For users, inbound/outbound is a direction. I proposed a sortable "Direction" column immediately next to the "Type" column to display Inbound/Outbound rather than the current arrows, it had an enthusiastic reception with ACKs by @hebasto and @jarolrod IIRC, but was opposed by another contributor. I could propose it again, e.g. like bitcoin-core/gui#179 (review) and bitcoin-core/gui#179 (review).

[maflcko]

Ok, closing for now.

If this is an issue, it might be good to file this in the gui repo instead.

[jonatack]

Yes, I'll have a look at this tomorrow over on the GUI repo. Edit: done, hopefully bitcoin-core/gui#289 makes this clearer.