Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional features for wallet data #63

Closed
notmandatory opened this issue Dec 8, 2021 · 3 comments · Fixed by #71
Closed

Add optional features for wallet data #63

notmandatory opened this issue Dec 8, 2021 · 3 comments · Fixed by #71
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@notmandatory
Copy link
Member

Currently bdk-cli can only use the bdk/key-value-db feature for wallet data storage. I propose we make the bdk/default memory database the default for bdk-cli, and add two new optional and mutually exclusive features that enable use of the bdk/key-value-db or sqlite DBs which override using the memory DB. These features could be named key-value-db and sqlite.

The purpose of this requested change is to make it possible to test bdk using the bdk-cli tool with any of the three possible wallet data storage options.

@notmandatory notmandatory added enhancement New feature or request good first issue Good for newcomers labels Dec 8, 2021
@rajarshimaitra rajarshimaitra linked a pull request Mar 7, 2022 that will close this issue
6 tasks
@notmandatory notmandatory added this to the Release 0.5.x milestone Mar 14, 2022
@notmandatory notmandatory self-assigned this Mar 14, 2022
@notmandatory
Copy link
Member Author

EDIT: If possible I'd like to make the database features NOT mutually exclusive.

@rajarshimaitra
Copy link
Contributor

I haven't fully grasped on the down side of not having mutually exclusive features.. Is that a very big problem? Many things especially like DB might make more sense to be mutually exclusive I feel?

@notmandatory
Copy link
Member Author

notmandatory commented Mar 14, 2022

Not having mutually exclusive features is recommended in the Cargo book but is probably more of an issue for libs than end bins like this project. But even here I think it would be useful to be able to enable all features and use them all without having to rebuild to enable/disable the ones I want to test with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants