Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Sqlite DB #83

Closed
rajarshimaitra opened this issue Apr 27, 2022 · 3 comments
Closed

Allow Sqlite DB #83

rajarshimaitra opened this issue Apr 27, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@rajarshimaitra
Copy link
Contributor

Currently bdk-cli only uses sled database. But BDK now supports sqlite too. This can be extended to bdk-cli using a sqlite feature flag.

Having Sqlite DB in wallet database can be useful for lib users in many situations.

@rajarshimaitra rajarshimaitra added enhancement New feature or request good first issue Good for newcomers labels Apr 27, 2022
@rajarshimaitra rajarshimaitra self-assigned this Apr 27, 2022
@notmandatory
Copy link
Member

I saw this and thought, good idea! Then I remembered I started it with PR #71, but need to get it rebased and cleaned up. But if anyone else is interested and wants to help with review and testing that would be great!

@rajarshimaitra
Copy link
Contributor Author

Yes I saw that one, and it fixes this.. Last I remember it was pending for additive feature capability.. But then again doesn't it make sense here to have wallet with only one db feature at a time?? What would it mean to have both sled and sqlite enabled??

In case we are not going towards that additive thing, then I think #71 works perfect.. I will review it again when its ready..

@notmandatory
Copy link
Member

Thanks, I'm going to merge #71 without the additive stuff for now.

@notmandatory notmandatory added this to the Release 0.5.0 milestone May 24, 2022
@notmandatory notmandatory self-assigned this May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

2 participants