diff --git a/.github/workflows/code_coverage.yml b/.github/workflows/code_coverage.yml index c9fab32d4..54020bb90 100644 --- a/.github/workflows/code_coverage.yml +++ b/.github/workflows/code_coverage.yml @@ -27,6 +27,7 @@ jobs: uses: Swatinem/rust-cache@v2.2.1 - name: Install grcov run: if [[ ! -e ~/.cargo/bin/grcov ]]; then cargo install grcov; fi + # TODO: re-enable the hwi tests - name: Build simulator image run: docker build -t hwi/ledger_emulator ./ci -f ci/Dockerfile.ledger - name: Run simulator image diff --git a/CHANGELOG.md b/CHANGELOG.md index 929501a18..854a40660 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -517,7 +517,7 @@ final transaction is created by calling `finish` on the builder. - Default to SIGHASH_ALL if not specified - Replace ChangeSpendPolicy::filter_utxos with a predicate - Make 'unspendable' into a HashSet -- Stop implicitly enforcing manaul selection by .add_utxo +- Stop implicitly enforcing manual selection by .add_utxo - Rename DumbCS to LargestFirstCoinSelection - Rename must_use_utxos to required_utxos - Rename may_use_utxos to optional_uxtos diff --git a/crates/bdk/src/descriptor/policy.rs b/crates/bdk/src/descriptor/policy.rs index 14b2459eb..008bbe9ae 100644 --- a/crates/bdk/src/descriptor/policy.rs +++ b/crates/bdk/src/descriptor/policy.rs @@ -521,7 +521,7 @@ pub enum PolicyError { impl fmt::Display for PolicyError { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { match self { - Self::NotEnoughItemsSelected(err) => write!(f, "Not enought items selected: {}", err), + Self::NotEnoughItemsSelected(err) => write!(f, "Not enough items selected: {}", err), Self::IndexOutOfRange(index) => write!(f, "Index out of range: {}", index), Self::AddOnLeaf => write!(f, "Add on leaf"), Self::AddOnPartialComplete => write!(f, "Add on partial complete"), diff --git a/crates/bdk/src/wallet/mod.rs b/crates/bdk/src/wallet/mod.rs index e396b8d4f..d3bc116e2 100644 --- a/crates/bdk/src/wallet/mod.rs +++ b/crates/bdk/src/wallet/mod.rs @@ -1459,7 +1459,7 @@ impl Wallet { }; // TODO: We should pay attention when adding a new output: this might increase - // the lenght of the "number of vouts" parameter by 2 bytes, potentially making + // the length of the "number of vouts" parameter by 2 bytes, potentially making // our feerate too low tx.output.push(drain_output); } diff --git a/crates/bdk/src/wallet/signer.rs b/crates/bdk/src/wallet/signer.rs index d71ba0e63..dfd4e78d0 100644 --- a/crates/bdk/src/wallet/signer.rs +++ b/crates/bdk/src/wallet/signer.rs @@ -754,7 +754,7 @@ pub struct SignOptions { /// Whether the signer should trust the `witness_utxo`, if the `non_witness_utxo` hasn't been /// provided /// - /// Defaults to `false` to mitigate the "SegWit bug" which chould trick the wallet into + /// Defaults to `false` to mitigate the "SegWit bug" which should trick the wallet into /// paying a fee larger than expected. /// /// Some wallets, especially if relatively old, might not provide the `non_witness_utxo` for diff --git a/crates/bdk/src/wallet/tx_builder.rs b/crates/bdk/src/wallet/tx_builder.rs index 37e85a124..3b88073a6 100644 --- a/crates/bdk/src/wallet/tx_builder.rs +++ b/crates/bdk/src/wallet/tx_builder.rs @@ -182,7 +182,7 @@ impl<'a, D, Cs: Clone, Ctx> Clone for TxBuilder<'a, D, Cs, Ctx> { impl<'a, D, Cs: CoinSelectionAlgorithm, Ctx: TxBuilderContext> TxBuilder<'a, D, Cs, Ctx> { /// Set a custom fee rate /// The fee_rate method sets the mining fee paid by the transaction as a rate on its size. - /// This means that the total fee paid is equal to this rate * size of the transaction in virtual Bytes (vB) or Weigth Unit (wu). + /// This means that the total fee paid is equal to this rate * size of the transaction in virtual Bytes (vB) or Weight Unit (wu). /// This rate is internally expressed in satoshis-per-virtual-bytes (sats/vB) using FeeRate::from_sat_per_vb, but can also be set by: /// * sats/kvB (1000 sats/kvB == 1 sats/vB) using FeeRate::from_sat_per_kvb /// * btc/kvB (0.00001000 btc/kvB == 1 sats/vB) using FeeRate::from_btc_per_kvb diff --git a/crates/bdk/tests/wallet.rs b/crates/bdk/tests/wallet.rs index 7161e58d1..15a80f8c1 100644 --- a/crates/bdk/tests/wallet.rs +++ b/crates/bdk/tests/wallet.rs @@ -1293,7 +1293,7 @@ fn test_add_foreign_utxo_where_outpoint_doesnt_match_psbt_input() { satisfaction_weight ) .is_ok(), - "shoulld be ok when outpoint does match psbt_input" + "should be ok when outpoint does match psbt_input" ); } @@ -2013,7 +2013,7 @@ fn test_bump_fee_add_input_change_dust() { let mut tx = psbt.extract_tx(); for txin in &mut tx.input { - txin.witness.push([0x00; P2WPKH_FAKE_WITNESS_SIZE]); // to get realisitc weight + txin.witness.push([0x00; P2WPKH_FAKE_WITNESS_SIZE]); // to get realistic weight } let original_tx_weight = tx.weight(); assert_eq!(tx.input.len(), 1); diff --git a/crates/bitcoind_rpc/tests/test_emitter.rs b/crates/bitcoind_rpc/tests/test_emitter.rs index d3c9e36bd..521124e5d 100644 --- a/crates/bitcoind_rpc/tests/test_emitter.rs +++ b/crates/bitcoind_rpc/tests/test_emitter.rs @@ -735,7 +735,7 @@ fn mempool_during_reorg() -> anyhow::Result<()> { "first mempool emission should include all txs", ); - // perform reorgs at different heights, these reorgs will not comfirm transactions in the + // perform reorgs at different heights, these reorgs will not confirm transactions in the // mempool for reorg_count in 1..TIP_DIFF { println!("REORG COUNT: {}", reorg_count); @@ -808,10 +808,10 @@ fn mempool_during_reorg() -> anyhow::Result<()> { /// If blockchain re-org includes the start height, emit new start height block /// /// 1. mine 101 blocks -/// 2. emmit blocks 99a, 100a +/// 2. emit blocks 99a, 100a /// 3. invalidate blocks 99a, 100a, 101a /// 4. mine new blocks 99b, 100b, 101b -/// 5. emmit block 99b +/// 5. emit block 99b /// /// The block hash of 99b should be different than 99a, but their previous block hashes should /// be the same. diff --git a/crates/chain/src/indexed_tx_graph.rs b/crates/chain/src/indexed_tx_graph.rs index 0e2620e0d..68e7846b6 100644 --- a/crates/chain/src/indexed_tx_graph.rs +++ b/crates/chain/src/indexed_tx_graph.rs @@ -160,7 +160,7 @@ where /// Batch insert unconfirmed transactions, filtering out those that are irrelevant. /// /// Relevancy is determined by the internal [`Indexer::is_tx_relevant`] implementation of `I`. - /// Irrelevant tansactions in `txs` will be ignored. + /// Irrelevant transactions in `txs` will be ignored. /// /// Items of `txs` are tuples containing the transaction and a *last seen* timestamp. The /// *last seen* communicates when the transaction is last seen in the mempool which is used for @@ -223,7 +223,7 @@ where /// [`AnchorFromBlockPosition::from_block_position`]. /// /// Relevancy is determined by the internal [`Indexer::is_tx_relevant`] implementation of `I`. - /// Irrelevant tansactions in `txs` will be ignored. + /// Irrelevant transactions in `txs` will be ignored. pub fn apply_block_relevant( &mut self, block: Block, diff --git a/crates/chain/src/tx_graph.rs b/crates/chain/src/tx_graph.rs index 802c74dc7..3348fb40e 100644 --- a/crates/chain/src/tx_graph.rs +++ b/crates/chain/src/tx_graph.rs @@ -480,7 +480,7 @@ impl TxGraph { /// Inserts the given `seen_at` for `txid` into [`TxGraph`]. /// - /// Note that [`TxGraph`] only keeps track of the lastest `seen_at`. + /// Note that [`TxGraph`] only keeps track of the latest `seen_at`. pub fn insert_seen_at(&mut self, txid: Txid, seen_at: u64) -> ChangeSet { let mut update = Self::default(); let (_, _, update_last_seen) = update.txs.entry(txid).or_default(); diff --git a/crates/chain/tests/test_tx_graph.rs b/crates/chain/tests/test_tx_graph.rs index 224e263b7..a71e24f99 100644 --- a/crates/chain/tests/test_tx_graph.rs +++ b/crates/chain/tests/test_tx_graph.rs @@ -15,7 +15,7 @@ use std::vec; #[test] fn insert_txouts() { - // 2 (Outpoint, TxOut) tupples that denotes original data in the graph, as partial transactions. + // 2 (Outpoint, TxOut) tuples that denotes original data in the graph, as partial transactions. let original_ops = [ ( OutPoint::new(h!("tx1"), 1), @@ -33,7 +33,7 @@ fn insert_txouts() { ), ]; - // Another (OutPoint, TxOut) tupple to be used as update as partial transaction. + // Another (OutPoint, TxOut) tuple to be used as update as partial transaction. let update_ops = [( OutPoint::new(h!("tx2"), 0), TxOut { diff --git a/example-crates/example_bitcoind_rpc_polling/src/main.rs b/example-crates/example_bitcoind_rpc_polling/src/main.rs index 6b30f01f6..35aa76907 100644 --- a/example-crates/example_bitcoind_rpc_polling/src/main.rs +++ b/example-crates/example_bitcoind_rpc_polling/src/main.rs @@ -32,7 +32,7 @@ const CHANNEL_BOUND: usize = 10; const STDOUT_PRINT_DELAY: Duration = Duration::from_secs(6); /// Delay between mempool emissions. const MEMPOOL_EMIT_DELAY: Duration = Duration::from_secs(30); -/// Delay for committing to persistance. +/// Delay for committing to persistence. const DB_COMMIT_DELAY: Duration = Duration::from_secs(60); type ChangeSet = ( @@ -184,7 +184,7 @@ fn main() -> anyhow::Result<()> { CheckPoint::from_header(&block.header, height).into_update(false); let chain_changeset = chain .apply_update(chain_update) - .expect("must always apply as we recieve blocks in order from emitter"); + .expect("must always apply as we receive blocks in order from emitter"); let graph_changeset = graph.apply_block_relevant(block, height); db.stage((chain_changeset, graph_changeset)); @@ -193,7 +193,7 @@ fn main() -> anyhow::Result<()> { last_db_commit = Instant::now(); db.commit()?; println!( - "[{:>10}s] commited to db (took {}s)", + "[{:>10}s] committed to db (took {}s)", start.elapsed().as_secs_f32(), last_db_commit.elapsed().as_secs_f32() ); @@ -298,7 +298,7 @@ fn main() -> anyhow::Result<()> { CheckPoint::from_header(&block.header, height).into_update(false); let chain_changeset = chain .apply_update(chain_update) - .expect("must always apply as we recieve blocks in order from emitter"); + .expect("must always apply as we receive blocks in order from emitter"); let graph_changeset = graph.apply_block_relevant(block, height); (chain_changeset, graph_changeset) } @@ -320,7 +320,7 @@ fn main() -> anyhow::Result<()> { last_db_commit = Instant::now(); db.commit()?; println!( - "[{:>10}s] commited to db (took {}s)", + "[{:>10}s] committed to db (took {}s)", start.elapsed().as_secs_f32(), last_db_commit.elapsed().as_secs_f32() ); diff --git a/example-crates/example_cli/src/lib.rs b/example-crates/example_cli/src/lib.rs index f9574c0e0..39b4f312e 100644 --- a/example-crates/example_cli/src/lib.rs +++ b/example-crates/example_cli/src/lib.rs @@ -78,7 +78,7 @@ pub enum Commands { #[clap(short, default_value = "bnb")] coin_select: CoinSelectionAlgo, #[clap(flatten)] - chain_specfic: S, + chain_specific: S, }, } @@ -585,7 +585,7 @@ where value, address, coin_select, - chain_specfic, + chain_specific, } => { let chain = &*chain.lock().unwrap(); let address = address.require_network(network)?; @@ -618,7 +618,7 @@ where } }; - match (broadcast)(chain_specfic, &transaction) { + match (broadcast)(chain_specific, &transaction) { Ok(_) => { println!("Broadcasted Tx : {}", transaction.txid()); diff --git a/example-crates/example_esplora/src/main.rs b/example-crates/example_esplora/src/main.rs index c294986ad..cabd8ea82 100644 --- a/example-crates/example_esplora/src/main.rs +++ b/example-crates/example_esplora/src/main.rs @@ -106,7 +106,7 @@ fn main() -> anyhow::Result<()> { let (init_chain_changeset, init_indexed_tx_graph_changeset) = init_changeset; - // Contruct `IndexedTxGraph` and `LocalChain` with our initial changeset. They are wrapped in + // Construct `IndexedTxGraph` and `LocalChain` with our initial changeset. They are wrapped in // `Mutex` to display how they can be used in a multithreaded context. Technically the mutexes // aren't strictly needed here. let graph = Mutex::new({ diff --git a/nursery/tmp_plan/src/lib.rs b/nursery/tmp_plan/src/lib.rs index dce190143..226ce8b59 100644 --- a/nursery/tmp_plan/src/lib.rs +++ b/nursery/tmp_plan/src/lib.rs @@ -315,7 +315,7 @@ where self.set_sequence.clone() } - /// The minmum required transaction version required on the transaction using the plan. + /// The minimum required transaction version required on the transaction using the plan. pub fn min_version(&self) -> Option { if let Some(_) = self.set_sequence { Some(2)