Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexer::index_tx can have a default impl in the trait. #1097

Open
Tracked by #76
evanlinjin opened this issue Aug 26, 2023 · 2 comments · May be fixed by #1176
Open
Tracked by #76

Indexer::index_tx can have a default impl in the trait. #1097

evanlinjin opened this issue Aug 26, 2023 · 2 comments · May be fixed by #1176
Assignees
@vladimirfomene
Labels
module-blockchain new feature New feature or request

Comments

@evanlinjin
Copy link
Member 

          I think this is a good idea. Also `index_tx` can have a default impl in the trait.

Originally posted by @LLFourn in #1084 (comment)
@evanlinjin evanlinjin mentioned this issue Aug 26, 2023
Merged
3 tasks
@nondiremanuel nondiremanuel mentioned this issue Sep 10, 2023
Closed
41 tasks
@evanlinjin evanlinjin added the good first issue Good for newcomers label Oct 11, 2023
@vladimirfomene
Copy link
Contributor

@evanlinjin as discussed, I'm taking this up.

@vladimirfomene vladimirfomene self-assigned this Oct 12, 2023
@vladimirfomene vladimirfomene linked a pull request Oct 12, 2023 that will close this issue
Open
4 tasks
@notmandatory notmandatory added this to the 1.0.0-alpha.4 milestone Nov 13, 2023
@nondiremanuel nondiremanuel modified the milestones: 1.0.0-alpha.4, 1.0.0 Jan 6, 2024
@LLFourn
Copy link
Contributor

LLFourn commented Feb 5, 2024

See #1176 (comment) why I no longer think this is a good idea.

@nondiremanuel nondiremanuel removed this from the 1.0.0-alpha milestone Mar 21, 2024
@notmandatory notmandatory removed the good first issue Good for newcomers label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladimirfomene vladimirfomene

Labels
module-blockchain new feature New feature or request
Projects
BDK
Status: Discussion
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement default index_tx method vladimirfomene/bdk
5 participants
@LLFourn @notmandatory @vladimirfomene @evanlinjin @nondiremanuel