Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: AbortError #1744

Merged
merged 1 commit into from
Aug 23, 2023
Merged

feat: AbortError #1744

merged 1 commit into from
Aug 23, 2023

Conversation

frederikprijck
Copy link

Purpose

Backport of 553bb5d to v2.

Changes

Exports the AbortError, which is used internally and thrown on a timeout. https://github.com/node-fetch/node-fetch/blob/2.x/src/index.js#L81

Additional information

#792

  • I updated readme
  • I added unit test(s)

@frederikprijck frederikprijck mentioned this pull request May 16, 2023
Closed
@Richienb
Copy link
Member

@node-fetch/core Is updating v2 like this still a thing we can and should do?

@gr2m gr2m changed the title Export AbortError in v2 feat: AbortError May 19, 2023
gr2m
gr2m approved these changes May 19, 2023
View reviewed changes
Copy link
Collaborator

@gr2m gr2m left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason not to. As long as it's not a breaking change

@frederikprijck
Copy link
Author

Following up on my open PRs, any plans to merge this? If not, I can close this.

@gr2m
Copy link
Collaborator

gr2m commented Aug 23, 2023

as there was no objection, I'm going to merge it in 👍🏼 Sorry for the delay

@gr2m gr2m merged commit 9b9d458 into node-fetch:2.x Aug 23, 2023
@github-actions
Copy link

🎉 This PR is included in version 2.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nikcorg nikcorg mentioned this pull request Oct 24, 2023
Merged
8 tasks
This was referenced May 19, 2024
Open
Open
This was referenced May 20, 2024
Closed
Closed
@ali8889 ali8889 mentioned this pull request May 21, 2024
Open
@snyk-io snyk-io bot mentioned this pull request May 21, 2024
Open
@Bad3r Bad3r mentioned this pull request May 22, 2024
Open
@lockyz lockyz mentioned this pull request May 22, 2024
Closed
@ali8889 ali8889 mentioned this pull request May 23, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@zygisk-topjohnu zygisk-topjohnu mentioned this pull request May 24, 2024
Open
@basharat-j basharat-j mentioned this pull request May 24, 2024
Open
@lockyz lockyz mentioned this pull request May 24, 2024
Closed
@NOUIY NOUIY mentioned this pull request May 24, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request May 24, 2024
Open
@reinaldoalmeida reinaldoalmeida mentioned this pull request May 24, 2024
Open
@neznaamey neznaamey mentioned this pull request May 24, 2024
Open
@ali8889 ali8889 mentioned this pull request May 25, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request May 25, 2024
Open
@neznaamey neznaamey mentioned this pull request Sep 21, 2024
Open
@ali8889 ali8889 mentioned this pull request Sep 22, 2024
Open
@neznaamey neznaamey mentioned this pull request Sep 22, 2024
Open
@TheAutisticTechie TheAutisticTechie mentioned this pull request Sep 22, 2024
Open
This was referenced Sep 23, 2024
Open
Open
@sindhuhack sindhuhack mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 25, 2024
Open
Open
Open
Open
Open
@xtrmbuster xtrmbuster mentioned this pull request Sep 29, 2024
Open
@ali8889 ali8889 mentioned this pull request Sep 30, 2024
Open
@Evildog255 Evildog255 mentioned this pull request Sep 30, 2024
Open
This was referenced Sep 30, 2024
Open
Open
Open
Open
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Oct 17, 2024
Open
@githubgamer112 githubgamer112 mentioned this pull request Oct 25, 2024
Open
@zanyx-web-sec zanyx-web-sec mentioned this pull request Oct 28, 2024
Open
@ali8889 ali8889 mentioned this pull request Oct 30, 2024
Open
@DaanV2 DaanV2 mentioned this pull request Oct 31, 2024
Closed
@mihaibuzgau mihaibuzgau mentioned this pull request Nov 1, 2024
Open
@SimplyTiramisu SimplyTiramisu mentioned this pull request Nov 1, 2024
Open
@dolevmiz1 dolevmiz1 mentioned this pull request Nov 2, 2024
Open
This was referenced Nov 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
released on @2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frederikprijck @Richienb @gr2m