Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

Allow custom login and error template #11

Closed
growse opened this issue Mar 7, 2014 · 4 comments · Fixed by #70
Closed

Allow custom login and error template #11

growse opened this issue Mar 7, 2014 · 4 comments · Fixed by #70

Comments

@growse
Copy link

growse commented Mar 7, 2014

The html template is currently hard-coded in templates.go. It'd be useful if there was an application switch that allowed specifying a custom template file for both the login and error pages.

@jehiah
Copy link
Member

jehiah commented Mar 7, 2014

Great idea. The default templates could use some work too.

@mikz
Copy link

mikz commented Aug 27, 2014

I would like to have the login in a popup, because we have the page in iframe and google sends x-frame-options: deny so it does not work.
Passing custom template would be awesome.

@timurb
Copy link

timurb commented Oct 26, 2014

I have not tried that but I think you can specify a template for an error page by nginx error_page directive: http://nginx.org/en/docs/http/ngx_http_core_module.html#error_page
Probably this would also work for a sign in page.

@jehiah
Copy link
Member

jehiah commented Nov 10, 2014

@timurb @mikz @growse I've updated the default templates quite a bit and want to know if the changes in #36 resolve this for you.

There is some ongoing conversation in #15 about this issue, so i'm going to close this and encourage you to chime in there if this is still of value with you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants