Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can.Model.list should depend on can/model not jquery/model #23

Merged
merged 1 commit into from
Mar 30, 2012

Conversation

cohuman
Copy link
Contributor

@cohuman cohuman commented Mar 30, 2012

We were running into some minor steal loading issues when using can.Model.List because it depending on jquery/model instead of can/model. It meant we had use a tiered "stealing" when including files with can.Model.List e.g.

steal('can/model').then('can/model/list') rather than steal('can/model', 'can/model/list') or even just steal('can/model/list')

@justinbmeyer
Copy link
Contributor

can.Model.List is already in model. The on at can/model/list is not supported and should not be used.

Sent from my iPhone

On Mar 30, 2012, at 11:59 AM, Cohuman Developerreply@reply.github.com wrote:

We were running into some minor steal loading issues when using can.Model.List because it depending on jquery/model instead of can/model. It meant we had use a tiered "stealing" when including files with can.Model.List e.g.

steal('can/model').then('can/model/list') rather than steal('can/model', 'can/model/list') or even just steal('can/model/list')

You can merge this Pull Request by running:

git pull https://github.com/cohuman/canjs master

Or you can view, comment on it, or merge it online at:

#23

-- Commit Summary --

  • can.Model.List depends on 'can/model'

-- File Changes --

M model/list/list.js (4)

-- Patch Links --

https://github.com/jupiterjs/canjs/pull/23.patch
https://github.com/jupiterjs/canjs/pull/23.diff


Reply to this email directly or view it on GitHub:
#23

justinbmeyer added a commit that referenced this pull request Mar 30, 2012
can.Model.list should depend on can/model not jquery/model
@justinbmeyer justinbmeyer merged commit d6ff28f into canjs:master Mar 30, 2012
justinbmeyer added a commit that referenced this pull request Jun 1, 2012
can.Model.list should depend on can/model not jquery/model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants