Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docco gitsubmodule isn't heroku friendly #26

Merged

Conversation

cohuman
Copy link
Contributor

@cohuman cohuman commented Apr 5, 2012

Unfortunately, heroku does not like the git@github.com format and needs the https format instead. When you try to deploy an app with submodules in the earlier format you get this in heroku:

/usr/bin/git push -f dev HEAD:master
Counting objects: 16, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (12/12), done.
Writing objects: 100% (12/12), 1.11 KiB, done.
Total 12 (delta 8), reused 0 (delta 0)

-----> Heroku receiving push
-----> Git submodules detected, installing
Submodule 'public/js/can' (https://github.com/cohuman/canjs.git) registered for path 'public/js/can'
Submodule 'public/js/cohuman/models' (https://cohumanjsmobile:asd&3sf1@github.com/cohuman/cohuman_js_models.git) registered for path 'public/js/cohuman/models'
Submodule 'public/js/steal' (https://github.com/jupiterjs/steal.git) registered for path 'public/js/steal'
Initialized empty Git repository in /disk1/tmp/build_34s125vxpi3cg/public/js/can/.git/
Submodule path 'public/js/can': checked out '8e4c6ae36d6979b1bd1d9cbb722c807e6546142f'
Submodule 'util/docco/docco' (https://github.com/jupiterjs/docco.git) registered for path 'util/docco/docco'
Initialized empty Git repository in /disk1/tmp/build_34s125vxpi3cg/public/js/can/util/docco/docco/.git/
Submodule path 'util/docco/docco': checked out 'cfa6aa22974288ae207b1411444d4411a90b6fee'
Initialized empty Git repository in /disk1/tmp/build_34s125vxpi3cg/public/js/cohuman/models/.git/
Submodule path 'public/js/cohuman/models': checked out 'd3979cdf66eea88f4f62a7e8e386e42bcce3d9f3'
Initialized empty Git repository in /disk1/tmp/build_34s125vxpi3cg/public/js/steal/.git/
Submodule path 'public/js/steal': checked out 'b91ad44abaadb74363d85fc961585f404bc32caf'

moschel added a commit that referenced this pull request Apr 6, 2012
…8150a93

docco gitsubmodule isn't heroku friendly
@moschel moschel merged commit 732938a into canjs:master Apr 6, 2012
@moschel
Copy link
Contributor

moschel commented Apr 6, 2012

Thanks, good call. The other URL only works if you have admin access on the repo

moschel added a commit that referenced this pull request Jun 1, 2012
…8150a93

docco gitsubmodule isn't heroku friendly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants